Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error msg in case no image produced #464

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Fix error msg in case no image produced #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/chains/storage/oci/oci.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,9 @@ func (b *Backend) StorePayload(ctx context.Context, tr *v1beta1.TaskRun, rawPayl
return b.uploadAttestation(attestation, signature, storageOpts, auth)
}

return errors.New("OCI storage backend is only supported for OCI images and in-toto attestations")
// Fallback in case unsupported payload format is used or the deprecated "tekton" format
b.logger.Info("Skipping upload to OCI registry, OCI storage backend is only supported for OCI images and in-toto attestations")
return nil
}

func (b *Backend) uploadSignature(format simple.SimpleContainerImage, rawPayload []byte, signature string, storageOpts config.StorageOpts, remoteOpts ...remote.Option) error {
Expand Down
28 changes: 28 additions & 0 deletions pkg/chains/storage/oci/oci_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,34 @@ func TestBackend_StorePayload(t *testing.T) {
},
wantErr: false,
},
{
name: "in-toto-and-simple-payload",
fields: fields{
tr: tr,
},
args: args{
payload: simple,
signature: "",
storageOpts: config.StorageOpts{
PayloadFormat: "in-toto",
},
},
wantErr: false,
},
{
name: "tekton-and-simple-payload",
fields: fields{
tr: tr,
},
args: args{
payload: simple,
signature: "",
storageOpts: config.StorageOpts{
PayloadFormat: "tekton",
},
},
wantErr: false,
},
{
name: "no subject",
fields: fields{
Expand Down