Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grafeas storage for PipelineRun-level provenance #601

Merged
merged 1 commit into from
Oct 22, 2022

Conversation

chuangw6
Copy link
Member

@chuangw6 chuangw6 commented Oct 21, 2022

Changes

/kind feature

Support storing pipelinerun level provenance in grafeas backend.

There are 3 main aspects of the PR:

  • created different BUILD Notes for storing both taskrun and pipelinerun level provenance/occurrence in grafeas that attest the same artifact.
  • extracted artifact identifiers from intoto subjects instead of calling individual helpers to extract from results.
  • changed TektonObject "GetKind" method to "GetGVK" to get the whole GroupVersionKind information.

Signed-off-by: Chuang Wang chuangw@google.com

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Support Grafeas storage for PipelineRun level provenance

Support storing pipelinerun level provenance in grafeas
backend.

There are 3 main aspects of the PR:
- created different BUILD Notes for storing both taskrun and pipelinerun
level provenance/occurrence in grafeas that attest the same artifact.
- extracted artifact identifiers from intoto subjects instead of calling
individual helpers to extract from results.
- changed TektonObject "GetKind" method to "GetGVK" to get the whole
GroupVersionKind information.

Signed-off-by: Chuang Wang <chuangw@google.com>
@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 21, 2022
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 21, 2022
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/intotoite6/extract/extract.go Do not exist 41.9%
pkg/chains/formats/intotoite6/taskrun/taskrun.go 75.4% 76.5% 1.1
pkg/chains/storage/grafeas/grafeas.go 78.8% 77.4% -1.4

@chuangw6
Copy link
Member Author

/retest

@chuangw6 chuangw6 closed this Oct 22, 2022
@chuangw6 chuangw6 reopened this Oct 22, 2022
Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2022
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2022
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/intotoite6/extract/extract.go Do not exist 41.9%
pkg/chains/formats/intotoite6/taskrun/taskrun.go 75.4% 76.5% 1.1
pkg/chains/storage/grafeas/grafeas.go 78.8% 77.4% -1.4

@chuangw6
Copy link
Member Author

Thank you so much @wlynch for the thorough review on this project. 👍

For complete review conversations, please see #590.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants