Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add PipelineRun support to storage/gcs #971

Merged
merged 1 commit into from
Oct 27, 2023
Merged

feat: add PipelineRun support to storage/gcs #971

merged 1 commit into from
Oct 27, 2023

Conversation

aaron-prindle
Copy link
Contributor

@aaron-prindle aaron-prindle commented Oct 26, 2023 •
edited
Loading

fixes #852

Prior to this commit the storage/gcs client didn't support PipelineRuns, only TaskRuns which is not in parity with our other storage interfaces. This PR adds PipelineRuns support to storage/gcs.

//nolint:staticcheck used similar to elsewhere in code as otherwise golangci-lint reports usage of deprecated v1beta1 APIs, snippet below:

  Error: SA1019: v1beta1.TaskRun is deprecated: Please use v1.TaskRun instead.  (staticcheck)
  Error: SA1019: v1beta1.PipelineRun is deprecated: Please use v1.PipelineRun instead.  (staticcheck)
  ...

NOTE: This is my first tektoncd/chains PR. If I misunderstood anything about the issue, changes necessary, best practices, etc. I'm happy to iterate as needed. Thanks!

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 26, 2023
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/storage/gcs/gcs.go 67.7% 69.5% 1.8

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/storage/gcs/gcs.go 67.7% 69.5% 1.8

@aaron-prindle aaron-prindle force-pushed the fix-852-v3 branch 3 times, most recently from 6a6f1f5 to 466c073 Compare October 26, 2023 23:57
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/storage/gcs/gcs.go 67.7% 69.5% 1.8

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/storage/gcs/gcs.go 67.7% 69.5% 1.8

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/storage/gcs/gcs.go 67.7% 69.5% 1.8

lcarva
lcarva reviewed Oct 27, 2023
View reviewed changes
Copy link
Contributor

@lcarva lcarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments, but overall this looks good!

pkg/chains/storage/gcs/gcs.go Outdated Show resolved Hide resolved
pkg/chains/storage/gcs/gcs.go Outdated Show resolved Hide resolved
@aaron-prindle
feat: add PipelineRun support to storage/gcs
69babbe 
Prior to this commit the storage/gcs client didn't support PipelineRuns, only TaskRuns which is not in parity with our other storage interfaces.  This PR adds PipelineRuns support to storage/gcs.
@aaron-prindle
Copy link
Contributor Author

Thanks for the review @lcarva! I believe I have addressed all of the feeback mentioned, lmk if there is anything additional to do here.

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/storage/gcs/gcs.go 67.7% 70.1% 2.4

lcarva
lcarva approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@lcarva lcarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2023
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcarva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2023
@tekton-robot tekton-robot merged commit f7f30c4 into tektoncd:main Oct 27, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcarva lcarva lcarva approved these changes

@chitrangpatel chitrangpatel Awaiting requested review from chitrangpatel

@wlynch wlynch Awaiting requested review from wlynch

Assignees

@lcarva lcarva

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

storage/gcs: PipelineRun support
3 participants
@aaron-prindle @tekton-robot @lcarva