Add resource list command #128

piyush-garg · 2019-06-26T12:40:20Z

Changes

This will add resource list command to
list all the pipelineresource available in the default
or provided namespace

It will show NAME and TYPE fields

Add docs regarding the new command

Add e2e test

This will fix #108

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Includes docs (if user facing)
Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

Add `tkn resource list` command

hrishin · 2019-06-26T12:42:27Z

/ok-to-test

pkg/cmd/pipelineresource/list.go

sthaha · 2019-06-26T12:47:49Z

pkg/cmd/pipelineresource/list.go

+
+	options := v1.ListOptions{}
+	prec := cs.Tekton.TektonV1alpha1().PipelineResources(p.Namespace())
+	pres, err := prec.List(options)


How about we group the objects by type?
I also wonder if we can ensure the order remains the same between subsequent invocations; perhaps sorted by time?.

@sthaha you mean type: ImageResource for a instance (resource.spec.type)`?

Good point. We can work this out in a follow-up :

Be able to group resources

Be able to filter based on resource types

pkg/cmd/root_test.go

pkg/cmd/pipelineresource/list_test.go

piyush-garg · 2019-06-26T14:07:43Z

/test pull-tekton-cli-go-coverage

pkg/cmd/pipelineresource/list.go

hrishin · 2019-06-26T16:50:22Z

/test pull-tekton-cli-go-coverage

piyush-garg · 2019-06-26T16:51:52Z

@hrishin I have addressed your review comment.

pkg/cmd/pipelineresource/list.go

hrishin

👍

We need to add a few more test cases.

pkg/cmd/pipelineresource/pipelineresource_test.go

piyush-garg · 2019-06-26T17:11:01Z

@hrishin Addressed

hrishin

few more comments (please)

docs/cmd/tkn_resource_list.md

pkg/cmd/pipelineresource/list.go

pkg/cmd/pipelineresource/list_test.go

hrishin

just last thing @piyush-garg ? then looks good

pkg/cmd/pipelineresource/list.go

hrishin · 2019-06-28T06:10:26Z

/LGTM

googlebot · 2019-07-02T13:16:36Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

linux-foundation-easycla · 2019-07-02T13:16:38Z

Thank you. Unfortunately, your account is not authorized under a signed CLA. Please click here to proceed.

❌ Piyush Garg (0faecf27658cb820bc7188bbf72a8cd68799f525)

googlebot · 2019-07-02T13:17:15Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

This will add resource list command to list all the pipelineresource available in the default or provided namespace It will show NAME and TYPE fields Add docs regarding the new command Add e2e test This will fix tektoncd#108

hrishin · 2019-07-03T08:38:26Z

@sthaha @vdemeester one more review round?

vdemeester

/lgtm
/meow boxes

We can enhance in follow-ups

vdemeester · 2019-07-03T09:01:59Z

docs/cmd/tkn_resource_list.md

+### Options inherited from parent commands
+
+```
+--azure-container-registry-config string         Path to the file containing Azure container registry configuration information.


nit: we need to prepare a follow-up to remove this flag everywhere in the docs 😹

vdemeester · 2019-07-03T09:03:11Z

pkg/cmd/pipelineresource/list.go

+
+	options := v1.ListOptions{}
+	prec := cs.Tekton.TektonV1alpha1().PipelineResources(p.Namespace())
+	pres, err := prec.List(options)


Good point. We can work this out in a follow-up :

Be able to group resources

Be able to filter based on resource types

vdemeester · 2019-07-03T09:03:54Z

pkg/cmd/root.go

-		Use:   "tkn",
-		Short: "CLI for tekton pipelines",
-		Long:  ``,
+		Use:                    "tkn",


This changes is weird (aka I don't see why goimports or gofmt would do that)

tekton-robot · 2019-07-03T09:04:17Z

@vdemeester: Bad category. Please see https://api.thecatapi.com/api/categories/list

In response to this:

/lgtm
/meow boxes

We can enhance in follow-ups

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot · 2019-07-03T09:04:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot requested review from hrishin and sthaha June 26, 2019 12:40

googlebot added the cla: yes label Jun 26, 2019

tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 26, 2019

piyush-garg changed the title ~~Iss 108~~ Add pipelineresource list command Jun 26, 2019

tekton-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 26, 2019

sthaha suggested changes Jun 26, 2019

View reviewed changes

pkg/cmd/pipelineresource/list.go Outdated Show resolved Hide resolved

sthaha reviewed Jun 26, 2019

View reviewed changes

pkg/cmd/root_test.go Outdated Show resolved Hide resolved

sthaha reviewed Jun 26, 2019

View reviewed changes

pkg/cmd/pipelineresource/list_test.go Outdated Show resolved Hide resolved

hrishin reviewed Jun 26, 2019

View reviewed changes

pkg/cmd/pipelineresource/list.go Outdated Show resolved Hide resolved

hrishin suggested changes Jun 26, 2019

View reviewed changes

pkg/cmd/pipelineresource/list.go Outdated Show resolved Hide resolved

pkg/cmd/pipelineresource/list.go Outdated Show resolved Hide resolved

hrishin suggested changes Jun 26, 2019

View reviewed changes

pkg/cmd/pipelineresource/pipelineresource_test.go Show resolved Hide resolved

hrishin suggested changes Jun 26, 2019

View reviewed changes

piyush-garg force-pushed the iss_108 branch from 87b839d to a5e075c Compare June 28, 2019 05:45

piyush-garg changed the title ~~Add pipelineresource list command~~ Add resource list command Jun 28, 2019

hrishin suggested changes Jun 28, 2019

View reviewed changes

pkg/cmd/pipelineresource/list.go Show resolved Hide resolved

piyush-garg force-pushed the iss_108 branch from a5e075c to 725d692 Compare June 28, 2019 06:01

tekton-robot assigned hrishin Jun 28, 2019

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2019

piyush-garg force-pushed the iss_108 branch from 725d692 to 0faecf2 Compare June 28, 2019 06:54

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2019

googlebot added cla: no and removed cla: yes labels Jul 2, 2019

vdemeester force-pushed the iss_108 branch from 2d58982 to 0faecf2 Compare July 2, 2019 13:17

googlebot added cla: yes and removed cla: no labels Jul 2, 2019

hrishin force-pushed the iss_108 branch 2 times, most recently from 6523bba to d880902 Compare July 2, 2019 17:44

hrishin requested review from sthaha and hrishin July 2, 2019 18:06

hrishin force-pushed the iss_108 branch from d880902 to 0d89aa4 Compare July 3, 2019 07:46

Add resource list command

c9f8110

This will add resource list command to list all the pipelineresource available in the default or provided namespace It will show NAME and TYPE fields Add docs regarding the new command Add e2e test This will fix tektoncd#108

hrishin force-pushed the iss_108 branch from 0d89aa4 to c9f8110 Compare July 3, 2019 08:08

vdemeester approved these changes Jul 3, 2019

View reviewed changes

tekton-robot assigned vdemeester Jul 3, 2019

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2019

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2019

This was referenced Jul 3, 2019

Remove --azure-container-registry-config from docs #146

Closed

Add filter flag to pipelineresource list #147

Closed

tekton-robot merged commit e05047e into tektoncd:master Jul 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add resource list command #128

Add resource list command #128

piyush-garg commented Jun 26, 2019 •

edited

Loading

hrishin commented Jun 26, 2019

sthaha Jun 26, 2019 •

edited

Loading

hrishin Jun 26, 2019

vdemeester Jul 3, 2019

piyush-garg commented Jun 26, 2019

hrishin commented Jun 26, 2019

piyush-garg commented Jun 26, 2019

hrishin left a comment

piyush-garg commented Jun 26, 2019

hrishin left a comment

hrishin left a comment

hrishin commented Jun 28, 2019

googlebot commented Jul 2, 2019

linux-foundation-easycla bot commented Jul 2, 2019 •

edited

Loading

googlebot commented Jul 2, 2019

hrishin commented Jul 3, 2019

vdemeester left a comment

vdemeester Jul 3, 2019

hrishin Jul 3, 2019

vdemeester Jul 3, 2019

vdemeester Jul 3, 2019

tekton-robot commented Jul 3, 2019

tekton-robot commented Jul 3, 2019

Add resource list command #128

Add resource list command #128

Conversation

piyush-garg commented Jun 26, 2019 • edited Loading

Changes

Submitter Checklist

Release Notes

hrishin commented Jun 26, 2019

sthaha Jun 26, 2019 • edited Loading

Choose a reason for hiding this comment

hrishin Jun 26, 2019

Choose a reason for hiding this comment

vdemeester Jul 3, 2019

Choose a reason for hiding this comment

piyush-garg commented Jun 26, 2019

hrishin commented Jun 26, 2019

piyush-garg commented Jun 26, 2019

hrishin left a comment

Choose a reason for hiding this comment

piyush-garg commented Jun 26, 2019

hrishin left a comment

Choose a reason for hiding this comment

hrishin left a comment

Choose a reason for hiding this comment

hrishin commented Jun 28, 2019

googlebot commented Jul 2, 2019

linux-foundation-easycla bot commented Jul 2, 2019 • edited Loading

googlebot commented Jul 2, 2019

hrishin commented Jul 3, 2019

vdemeester left a comment

Choose a reason for hiding this comment

vdemeester Jul 3, 2019

Choose a reason for hiding this comment

hrishin Jul 3, 2019

Choose a reason for hiding this comment

vdemeester Jul 3, 2019

Choose a reason for hiding this comment

vdemeester Jul 3, 2019

Choose a reason for hiding this comment

tekton-robot commented Jul 3, 2019

tekton-robot commented Jul 3, 2019

piyush-garg commented Jun 26, 2019 •

edited

Loading

sthaha Jun 26, 2019 •

edited

Loading

linux-foundation-easycla bot commented Jul 2, 2019 •

edited

Loading