Do not panic when template fails to execute #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tekton-robot
added
approved
|
@vdemeester do you know why @hrishin did you sign a new CLA? |
|
@sthaha old CLA is not working for me. I didn't sign new CLA. |
|
I think it has introduced Linux Foundation CLA as well. Is it @vdemeester ? |
|
I signed it |
|
/retest |
|
@sthaha needs a rebase 👼 |
PipelineRun describe command panics when templates fails to execute. This patch changes the behaviour to write errors to stderr when template execution fails Signed-Off-By: sthaha@redhat.com
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sthaha, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PipelineRun describe command panics when templates fails to execute.
This patch changes the behaviour to write errors to stderr when
template execution fails
Signed-Off-By: sthaha@redhat.com
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.
Release Notes