Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bundle push authentication error #1724

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Fix bundle push authentication error #1724

merged 1 commit into from
Sep 28, 2022

Conversation

digglife
Copy link
Contributor

Changes

go-containerregistry now raises error when both keychain and auth are set(google/go-containerregistry#1334). With this commit, tkn will ignore keychain when auth is provided with flag.

fixes: #1718

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

Release Notes

NONE

@digglife
Fix bundle push authentication error
9e106a6 
go-containerregistry now raises error when both keychain and auth are
set(google/go-containerregistry#1334). With this commit, tkn will ignore
keychain when auth is provided with flag.

fixes: tektoncd#1718
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Sep 22, 2022
@tekton-robot
Copy link
Contributor

Hi @digglife. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 22, 2022
@chmouel
Copy link
Member

chmouel commented Sep 22, 2022

/cc @vdemeester

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 22, 2022
@digglife
Copy link
Contributor Author

/retest

@digglife
Copy link
Contributor Author

The two errors in the E2E test are apparently not random or temporary, because every open PR got the same errors.

Seem that the PVC claim didn't work, not sure why though.

vinamra28
vinamra28 reviewed Sep 24, 2022
View reviewed changes
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/cc @piyush-garg @pradeepitm12

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2022
@piyush-garg
Copy link
Contributor

/retest

@piyush-garg
Copy link
Contributor

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2022
@chmouel
Copy link
Member

chmouel commented Sep 27, 2022

/lgtm

@digglife
Copy link
Contributor Author

@piyush-garg

The E2E test failed because https://storage.googleapis.com/tekton-releases/pipeline/latest/release.yaml has not updated to v0.40.1. I guess there was something wrong during releasing.

@vdemeester
Copy link
Member

@piyush-garg

The E2E test failed because https://storage.googleapis.com/tekton-releases/pipeline/latest/release.yaml has not updated to v0.40.1. I guess there was something wrong during releasing.

ah this is my fault 🤦🏼

@vdemeester
Copy link
Member

/retest

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [piyush-garg,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@piyush-garg
Copy link
Contributor

/retest

@tekton-robot tekton-robot merged commit 7d958cf into tektoncd:main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinamra28 vinamra28 vinamra28 left review comments

@vdemeester vdemeester vdemeester approved these changes

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

Assignees

@chmouel chmouel

@vinamra28 vinamra28

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bundle push not working when authentication is passed through args
6 participants
@digglife @tekton-robot @chmouel @piyush-garg @vdemeester @vinamra28