Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the TEP workflow #142

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

afrittoli
Copy link
Member

@afrittoli afrittoli commented Jul 7, 2020

Update the TEP workflow to make the PR that changes the status
of a proposed TEP the central place to track discussion on the
TEP.

This was discussed during an API WG.

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 7, 2020
@afrittoli
Copy link
Member Author

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2020
Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

about the impact on users, or some time to socialize it with the
Working Groups, etc. This state doesn't prevent using
`tektoncd/experimental` to *experiment* and gather feedback.

The outcome may be that the TEP is approved, and moves to
`implementable`, or rejected, and moves to `withdrawn`. In case the
TEP is `witdhdrawn` it's best practise to update it with the reason
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: withdrawn

The outcome may be that the TEP is approved, and moves to
`implementable`, or rejected, and moves to `withdrawn`. In case the
TEP is `witdhdrawn` it's best practise to update it with the reason
for widthdrwal.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: withdrawal

Update the TEP workflow to make the PR that changes the status
of a proposed TEP the central place to track discussion on the
TEP.

This was discussed during an API WG.
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2020
@bobcatfish
Copy link
Contributor

/lgtm

I'm assuming enough of us have looked it so I'm gonna throw in:

/approve

Thanks @afrittoli !

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2020
@tekton-robot tekton-robot merged commit 29476a4 into tektoncd:master Jul 7, 2020
dlorenc pushed a commit to dlorenc/community that referenced this pull request Oct 27, 2022
…ncd#142)

Signed-off-by: Priya Wadhwa <priya@chainguard.dev>

Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants