-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to the TEP workflow #142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
about the impact on users, or some time to socialize it with the | ||
Working Groups, etc. This state doesn't prevent using | ||
`tektoncd/experimental` to *experiment* and gather feedback. | ||
|
||
The outcome may be that the TEP is approved, and moves to | ||
`implementable`, or rejected, and moves to `withdrawn`. In case the | ||
TEP is `witdhdrawn` it's best practise to update it with the reason |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: withdrawn
The outcome may be that the TEP is approved, and moves to | ||
`implementable`, or rejected, and moves to `withdrawn`. In case the | ||
TEP is `witdhdrawn` it's best practise to update it with the reason | ||
for widthdrwal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: withdrawal
Update the TEP workflow to make the PR that changes the status of a proposed TEP the central place to track discussion on the TEP. This was discussed during an API WG.
445dd6d
to
daefd27
Compare
/lgtm I'm assuming enough of us have looked it so I'm gonna throw in: /approve Thanks @afrittoli ! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobcatfish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ncd#142) Signed-off-by: Priya Wadhwa <priya@chainguard.dev> Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
Update the TEP workflow to make the PR that changes the status
of a proposed TEP the central place to track discussion on the
TEP.
This was discussed during an API WG.