-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script and voters list for Feb 2021 elections #359
Conversation
Add a second script to resolve github user ids, that reduces a bit the amount of work that needs to be done with the original script. Add an updated user list for 2021. Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
/cc @iancoffey @bobcatfish 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly just wondering if we could delete the previous script in favor of the new one
@@ -1,4 +1,4 @@ | |||
#!/user/bin/env python3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅
@@ -0,0 +1,51 @@ | |||
#!/usr/bin/env python3 | |||
|
|||
"""get_emails_2.py Extracts github IDs from a CSV and matches them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason not to replace the other script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can run this first on the output of grafana, and then run the other script on the missing list produced by this script.
Reason being that the first script is more likely to give clean results, but also to have many miss.
I should have documented this better? Or maybe aggregated the two steps? I was a bit lazy :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this lgtm, thanks for doing this
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Add a second script to resolve github user ids, that reduces a bit
the amount of work that needs to be done with the original script.
Add an updated user list for 2021.
Signed-off-by: Andrea Frittoli andrea.frittoli@gmail.com