TEP-0103: Skipping Reason #671
Conversation
tekton-robot
added
the
size/L
|
/assign |
| [skipped-tasks]: https://github.com/tektoncd/pipeline/blob/053833cb10f3829d5a366daa1f431b293dcf3285/pkg/apis/pipeline/v1beta1/pipelinerun_types.go#L466-L476 | ||
| [issue-4738]: https://github.com/tektoncd/pipeline/issues/4738 | ||
| [issue-4571]: https://github.com/tektoncd/pipeline/issues/4571 | ||
| [slack]: https://tektoncd.slack.com/archives/CK3HBG7CM/p1642349040014100 |
There was a problem hiding this comment.
just fyi I don't think this slack link is available any longer, do you have a screenshot or text snippet of what was said? if not it's not a big deal
There was a problem hiding this comment.
we lose threads because we don't have a premium account so it's capped at 10K messages - added an item to the community meeting to discuss getting a premium subscription because it's our main means of communication
unfortunately, I didn't take a screenshot of that particular thread - hopefully we can recover it and others if we get a paid subscription 🤞🏾
| Name string `json:"name"` | ||
|
|
||
| // Reason is the cause of the PipelineTask being skipped | ||
| Reason SkippingReason `json:"reason"` |
There was a problem hiding this comment.
any reason not to put this info into TaskRun.Status.Condition.Reason instead of creating a separate field? what is in the Condition.Reason when a TaskRun is skipped?
There was a problem hiding this comment.
any reason not to put this info into TaskRun.Status.Condition.Reason instead of creating a separate field? what is in the Condition.Reason when a TaskRun is skipped?
We do not create a TaskRun for a skipped PipelineTask so there's no TaskRun.Status.Condition.Reason field for a skipped PipelineTask -- this is why we added the SkippedTasks field to the PipelineRun to list all the skipped PipelineTasks
tekton-robot
added
the
needs-rebase
Today, users only know that a `PipelineTask` was skipped, but they don't know for which exact reason. In this TEP, we propose adding the reason for skipping to `SkippedTasks` field in `PipelineRunStatus` to improve usability and debuggability.
tekton-robot
removed
the
needs-rebase
|
/kind tep |
tekton-robot
added
the
kind/tep
|
/assign vdemeester |
|
|
||
| There are many [reasons][reasons] why a `PipelineTask` could be skipped, including: | ||
| * at least one of its `when` expressions evaluated to false | ||
| * at least one of its `Conditions` failed |
There was a problem hiding this comment.
As Conditions are deprecated and will soon be removed, should we even try to support that ? 😛
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Today, users only know that a
PipelineTaskwas skipped, but they don't know for which exact reason. In this TEP, we propose adding the reason for skipping toSkippedTasksfield inPipelineRunStatusto improve usability and debuggability.References: