Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete test mock #1989

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Remove obsolete test mock #1989

merged 1 commit into from
Mar 26, 2021

Conversation

AlanGreene
Copy link
Member

Changes

#907 (comment)

Remove the test mock for focus-trap since it's no longer in use
by Carbon and won't be affecting our test stability any more.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

Remove the test mock for focus-trap since it's no longer in use
by Carbon and won't be affecting our test stability any more.
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 24, 2021
@skaegi
Copy link
Contributor

skaegi commented Mar 25, 2021

/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skaegi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2021
@AlanGreene
Copy link
Member Author

/cc @briangleeson
/uncc @ziheng

@tekton-robot tekton-robot requested review from briangleeson and removed request for ziheng March 25, 2021 19:09
@briangleeson
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2021
@tekton-robot tekton-robot merged commit 10fcff1 into tektoncd:main Mar 26, 2021
@AlanGreene AlanGreene deleted the focustrap branch March 26, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants