Update design of error page for page / resource not found #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
do-not-merge/work-in-progress
AlanGreene
force-pushed
the
notfound
branch
3 times, most recently
from
69c56c8
to
da57a4e
Compare
tekton-robot
removed
the
do-not-merge/work-in-progress
briangleeson
reviewed
Dec 8, 2021
Add a new component which can be used as an error page in case the user attempts to access a page / resource to which they do not have access or which does not exist. Use the robocat image instead of the Carbon error notification component, and provide links to commonly accessed pages as suggestions for next steps instead of leaving the user on an error page with no actions. Enable this new design for users attempting to access 'Import Resources' and 'Create' pages when the Dashboard is deployed in read-only mode, and as the fallback URL when an unknown path is found. This will be used more broadly in future with user permissions etc.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Resolves #2244
Add a new component which can be used as an error page in case the user
attempts to access a page / resource to which they do not have access or
which does not exist.
Use the robocat image instead of the Carbon error notification component,
and provide links to commonly accessed pages as suggestions for next steps
instead of leaving the user on an error page with no actions.
Enable this new design for users attempting to access 'Import Resources'
and 'Create' pages when the Dashboard is deployed in read-only mode, and
as the fallback URL when an unknown path is found.
This will be used more broadly in future with user permissions etc.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.