Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch functional components to useIntl hook #2499

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

AlanGreene
Copy link
Member

Changes

Reduce the number of HOC used in the component tree and prepare for future React improvements by switching all function-based component to use the useIntl hook provided by react-intl instead of the injectIntl HOC.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

See the contribution guide
for more details.

@tekton-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 1, 2022
@AlanGreene
Copy link
Member Author

/test all

@AlanGreene AlanGreene changed the title Switch functional components to hook Switch functional components to useIntl hook Oct 2, 2022
Reduce the number of HOC used in the component tree and prepare
for future React improvements by switching all function-based
component to use the `useIntl` hook provided by react-intl instead
of the `injectIntl` HOC.
@AlanGreene AlanGreene marked this pull request as ready for review October 2, 2022 20:17
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2022
@tekton-robot tekton-robot requested a review from skaegi October 2, 2022 20:17
@AlanGreene AlanGreene removed the request for review from skaegi October 2, 2022 20:17
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2022
@tekton-robot tekton-robot merged commit a338f20 into tektoncd:main Oct 3, 2022
@AlanGreene AlanGreene deleted the intl branch October 3, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants