Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase e2e poll timeout to 10min #821

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

nikhil-thomas
Copy link
Member

Set e2e poll timeout to 10 min to avoid flakes like

    tektonconfigs.go:122: TektonConfigCR "config" failed to get to the READY status: tektonconfig config is not in desired state, got: <nil>: timed out waiting for the condition

This is necessary because of the new wait on namespace deletion at the end of each e2e test group.

Signed-off-by: Nikhil Thomas nikthoma@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 1, 2022
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 1, 2022
@sm43 sm43 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2022
@nikhil-thomas
Copy link
Member Author

/retest

Set e2e poll timeout to 10 min to avoid flakes like

```
    tektonconfigs.go:122: TektonConfigCR "config" failed to get to the READY status: tektonconfig config is not in desired state, got: <nil>: timed out waiting for the condition
```

Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2022
@concaf
Copy link
Contributor

concaf commented Jun 2, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2022
@tekton-robot tekton-robot merged commit 5404a42 into tektoncd:main Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants