Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chains secret getting overwritten on upgrade #863

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

piyush-garg
Copy link
Contributor

@piyush-garg piyush-garg commented Jun 27, 2022

This will fix chains' secret getting overwritten over upgrade

Now the secret has been moved out to a separate installerset and
this installerset will not be removed and changed over upgrade.

This installlerset will only be deleted if the namespace
of the tektonchains gets changed.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Fix chains secret getting overwritten on upgrade

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 27, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 27, 2022
@sm43 sm43 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2022
@concaf
Copy link
Contributor

concaf commented Jun 27, 2022

/hold
testing this locally

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2022
This will fix chains secret getting overwritten over upgrade

Now the secret has been moved out to a separate installerset and
this installerset will not be removed and changed over upgrade.

This installlerset will only be deleted if the namespace
of the tektonchains gets changed.
@sm43
Copy link
Member

sm43 commented Jun 27, 2022

LGTM

@piyush-garg
Copy link
Contributor Author

In this scenario, I did not choose the approach of applying secret directly without installerset and keeping the ChainsCR as owner, because in the case of chain CR is edited to install in a different namespace, we need to handle explicitly the case of secret deletion etc. So to achieve that, created a secret in a separate installerset and this installerset will be deleted only on the change of namespace for now else not, and removing chains will also delete the secret.

@concaf
Copy link
Contributor

concaf commented Jun 27, 2022

/hold cancel
/approve
/lgtm

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2022
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2022
Copy link
Contributor

@concaf concaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: concaf, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit a3407f7 into tektoncd:main Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants