-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix chains secret getting overwritten on upgrade #863
Conversation
bea4b18
to
8b305ce
Compare
/hold |
This will fix chains secret getting overwritten over upgrade Now the secret has been moved out to a separate installerset and this installerset will not be removed and changed over upgrade. This installlerset will only be deleted if the namespace of the tektonchains gets changed.
8b305ce
to
d891dc6
Compare
LGTM |
In this scenario, I did not choose the approach of applying secret directly without installerset and keeping the ChainsCR as owner, because in the case of chain CR is edited to install in a different namespace, we need to handle explicitly the case of secret deletion etc. So to achieve that, created a secret in a separate installerset and this installerset will be deleted only on the change of namespace for now else not, and removing chains will also delete the secret. |
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: concaf, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This will fix chains' secret getting overwritten over upgrade
Now the secret has been moved out to a separate installerset and
this installerset will not be removed and changed over upgrade.
This installlerset will only be deleted if the namespace
of the tektonchains gets changed.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes