-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This commit removes the third_party directory, and updates hack/update-deps.sh to not store licenses in the third_party directory. It also removes symlinks to third_party in the kodata folders of code in cmd/, which results in third_party not being included in the images built from these directories. The reason we have the third_party directory is because some of our dependencies may have licenses that require distributing source code along with built images. However, we already include the (compressed) vendor directory in built images (see the [release pipeline](https://github.com/tektoncd/pipeline/blob/bf26bfb35745b403ac8ca760068f4d102e441940/tekton/publish.yaml#L139-L152)). The reason to remove third_party is because it is redundant with the vendor directory, included in unit tests, and CI does not enforce keeping it up to date. As an alternative to this commit, we could instead enforce that third_party is kept up to date via hack/verify-codegen.sh.
- Loading branch information
Showing
247 changed files
with
1 addition
and
36,481 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -58,5 +58,3 @@ if [[ -d hack/patches ]];then | |
git apply ${f} | ||
done | ||
fi | ||
|
||
update_licenses third_party/ |
202 changes: 0 additions & 202 deletions
202
third_party/cloud.google.com/go/compute/metadata/LICENSE
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.