tests

tektoncd · Apr 19, 2021 · f172c20 · f172c20
1 parent 338077b
commit f172c20
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 40 deletions.
diff --git a/pkg/apis/pipeline/v1alpha1/pipeline_validation_test.go b/pkg/apis/pipeline/v1alpha1/pipeline_validation_test.go
@@ -44,18 +44,6 @@ func TestPipeline_Validate(t *testing.T) {
 			},
 		},
 		failureExpected: false,
-	}, {
-		name: "period in name",
-		p: &v1alpha1.Pipeline{
-			ObjectMeta: metav1.ObjectMeta{Name: "pipe.line"},
-			Spec: v1alpha1.PipelineSpec{
-				Tasks: []v1alpha1.PipelineTask{{
-					Name:    "foo",
-					TaskRef: &v1alpha1.TaskRef{Name: "foo-task"},
-				}},
-			},
-		},
-		failureExpected: true,
 	}, {
 		name: "pipeline name too long",
 		p: &v1alpha1.Pipeline{

diff --git a/pkg/apis/pipeline/v1alpha1/pipelinerun_validation_test.go b/pkg/apis/pipeline/v1alpha1/pipelinerun_validation_test.go
@@ -45,17 +45,6 @@ func TestPipelineRun_Invalidate(t *testing.T) {
 			want: apis.ErrMissingField("spec"),
 		},
 		{
-			name: "invalid pipelinerun metadata",
-			pr: v1alpha1.PipelineRun{
-				ObjectMeta: metav1.ObjectMeta{
-					Name: "pipelinerun.name",
-				},
-			},
-			want: &apis.FieldError{
-				Message: "Invalid resource name: special character . must not be present",
-				Paths:   []string{"metadata.name"},
-			},
-		}, {
 			name: "no pipeline reference",
 			pr: v1alpha1.PipelineRun{
 				ObjectMeta: metav1.ObjectMeta{

diff --git a/pkg/apis/pipeline/v1alpha1/run_validation_test.go b/pkg/apis/pipeline/v1alpha1/run_validation_test.go
@@ -25,7 +25,6 @@ import (
 	v1beta1 "github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1"
 	"github.com/tektoncd/pipeline/test/diff"
 	corev1 "k8s.io/api/core/v1"
-	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"knative.dev/pkg/apis"
 )
 
@@ -38,15 +37,6 @@ func TestRun_Invalid(t *testing.T) {
 		name: "missing spec",
 		run:  &v1alpha1.Run{},
 		want: apis.ErrMissingField("spec"),
-	}, {
-		name: "invalid metadata",
-		run: &v1alpha1.Run{
-			ObjectMeta: metav1.ObjectMeta{Name: "run.name"},
-		},
-		want: &apis.FieldError{
-			Message: "Invalid resource name: special character . must not be present",
-			Paths:   []string{"metadata.name"},
-		},
 	}, {
 		name: "missing ref",
 		run: &v1alpha1.Run{

diff --git a/pkg/apis/pipeline/v1alpha1/taskrun_validation_test.go b/pkg/apis/pipeline/v1alpha1/taskrun_validation_test.go
@@ -40,13 +40,6 @@ func TestTaskRun_Invalid(t *testing.T) {
 		name: "invalid taskspec",
 		task: tb.TaskRun("taskmetaname"),
 		want: apis.ErrMissingField("spec"),
-	}, {
-		name: "invalid taskrun metadata",
-		task: tb.TaskRun("task.name"),
-		want: &apis.FieldError{
-			Message: "Invalid resource name: special character . must not be present",
-			Paths:   []string{"metadata.name"},
-		},
 	}}
 	for _, ts := range tests {
 		t.Run(ts.name, func(t *testing.T) {