Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create git output that updates git #1280

Closed
bobcatfish opened this issue Sep 5, 2019 · 4 comments
Closed

Create git output that updates git #1280

bobcatfish opened this issue Sep 5, 2019 · 4 comments
Labels
kind/design Categorizes issue or PR as related to design. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@bobcatfish
Copy link
Collaborator

Expected Behavior

As discussed in #1076, if a git PipelineResource is used as an output, this should cause a change in the outside world, i.e. for git the most appropriate action would be to create a new git commit. And in #1279 we want to make PipelineResoruces immutable, i.e. using a resource as a output would create a new PipelineResource.

This would mean that any Task that has a git PipelineResource output should:

  1. Create a new PipelineResource instance
  2. Create a commit in the backing git repo (it would have to have permission to push to that repo)

Actual Behavior

At the moment a git PipelineResource basically acts like a PVC only when used as an output (i.e. a way to share files). In #1109 we'll remove that functionality.

Additional Info

Blocked on design decisions in #1279

@ghost
Copy link

ghost commented Dec 5, 2019

The pipeline resources revamp described by #1673 proposes a solution to this issue by allowing customisation of a resource's behaviour when in rw/create mode. So, for example, the catalog's hypothetical Git resource could include an RW mode that git pushes back to the remote repo, writes out the SHA that was pushed, and allows other tasks in a pipeline to rely on those resources.

I'm going to link to this from that epic so that we can track support of this feature as part of that work.

@ghost ghost mentioned this issue Dec 5, 2019
@ghost ghost added kind/design Categorizes issue or PR as related to design. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Dec 5, 2019
@afrittoli afrittoli removed the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jun 15, 2020
@tekton-robot
Copy link
Collaborator

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Collaborator

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 14, 2020
@tekton-robot
Copy link
Collaborator

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/design Categorizes issue or PR as related to design. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants