Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in error message #5983

Closed
data-henrik opened this issue Jan 11, 2023 · 17 comments
Closed

Typo in error message #5983

data-henrik opened this issue Jan 11, 2023 · 17 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@data-henrik
Copy link

return nil, errors.New("Both ResourseRef and ResourceSpec are defined. Expected only one")
}
if r.ResourceRef != nil && r.ResourceRef.Name != "" {
return getter(r.ResourceRef.Name)
}
if r.ResourceSpec != nil {
return &resourcev1alpha1.PipelineResource{
ObjectMeta: metav1.ObjectMeta{
Name: r.Name,
},
Spec: *r.ResourceSpec,
}, nil
}
return nil, errors.New("Neither ResourseRef nor ResourceSpec is defined")

I ran into this error message:

Neither ResourseRef nor ResourceSpec is defined

It should be "ResourceRef"

@data-henrik data-henrik added the kind/bug Categorizes issue or PR as related to a bug. label Jan 11, 2023
@vdemeester vdemeester added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jan 31, 2023
@codeleongy
Copy link

codeleongy commented Feb 1, 2023

Hi @data-henrik @vdemeester , I am interested in fixing this bug, could you assign to me: )

@vdemeester
Copy link
Member

@codeleongy if you comment /assign it should assign it to you automatically 😉

/assign @codeleongy

@Dev-Ashank
Copy link

/assign

@Dev-Ashank
Copy link

/unassign

@Aathirajan
Copy link
Contributor

/assign

@Aathirajan
Copy link
Contributor

/unassign

@Aathirajan
Copy link
Contributor

/assign

@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 3, 2023
@tekton-robot
Copy link
Collaborator

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 3, 2023
@data-henrik
Copy link
Author

/lifecycle frozen "it should be fixed for quality reasons"

@vdemeester
Copy link
Member

/lifecycle frozen

@tekton-robot tekton-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jul 3, 2023
@AlanGreene
Copy link
Member

AlanGreene commented Jul 3, 2023

Looks like this was fixed in #6184 which was first released in v0.46.0
/close

@tekton-robot
Copy link
Collaborator

@AlanGreene: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

Looks like this was fixed in #6184 which was first release in v0.46.0
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aaron-prindle
Copy link
Contributor

+1 @AlanGreene, this was fixed with #6184
/close

@tekton-robot
Copy link
Collaborator

@aaron-prindle: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

+1 @AlanGreene, this was fixed with #6184
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dibyom
Copy link
Member

dibyom commented Aug 29, 2023

/close

@tekton-robot
Copy link
Collaborator

@dibyom: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
Status: Done
Development

No branches or pull requests

10 participants