Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor - evaluate package matrix #6277

Closed
pritidesai opened this issue Mar 2, 2023 · 0 comments · Fixed by #6282
Closed

refactor - evaluate package matrix #6277

pritidesai opened this issue Mar 2, 2023 · 0 comments · Fixed by #6282
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@pritidesai
Copy link
Member

In PR #6246, while refactoring a function FanOut which is part of matrix package and works with Matrix.Params, we were not able to convert that function into a member function to struct Matrix. This was resulting in a cyclic import. Please refer to the comments for more details.

This issue is keeping track for a refactoring of the existing code base and addressing the question in #6246 (comment).
@pritidesai pritidesai mentioned this issue Mar 2, 2023
Merged
7 tasks
jerop added a commit to jerop/pipeline that referenced this issue Mar 2, 2023
@jerop
Reorganizing Matrix Implementation
f5e34a8 
In this change, we reorganize the code implementing Matrix.
This is to make it easier to make changes to Matrix, such as adding
Matrix.Include, as we work towards a Beta release. This refactor
also enables us to define member function of Matrix type.

There are no functional changes in this commit.

Fixes: tektoncd#6277.
@jerop jerop mentioned this issue Mar 2, 2023
Merged
3 tasks
jerop added a commit to jerop/pipeline that referenced this issue Mar 2, 2023
@jerop
Reorganizing Matrix Implementation
8091416 
In this change, we reorganize the code implementing Matrix.
This is to make it easier to make changes to Matrix, such as adding
Matrix.Include, as we work towards a Beta release. This refactor
also enables us to define member function of Matrix type.

There are no functional changes in this commit.

Fixes: tektoncd#6277.
jerop added a commit to jerop/pipeline that referenced this issue Mar 2, 2023
@jerop
Reorganizing Matrix Implementation
d64d296 
In this change, we reorganize the code implementing Matrix.
This is to make it easier to make changes to Matrix, such as adding
Matrix.Include, as we work towards a Beta release. This refactor
also enables us to define member function of Matrix type.

There are no functional changes in this commit.

Fixes: tektoncd#6277.
jerop added a commit to jerop/pipeline that referenced this issue Mar 3, 2023
@jerop
Reorganizing Matrix Implementation
2cf3f60 
In this change, we reorganize the code implementing Matrix.
This is to make it easier to make changes to Matrix, such as adding
Matrix.Include, as we work towards a Beta release. This refactor
also enables us to define member function of Matrix type.

There are no functional changes in this commit.

Fixes: tektoncd#6277.
jerop added a commit to jerop/pipeline that referenced this issue Mar 3, 2023
@jerop
Reorganizing Matrix Implementation
ca30a6f 
In this change, we reorganize the code implementing Matrix.
This is to make it easier to make changes to Matrix, such as adding
Matrix.Include, as we work towards a Beta release. This refactor
also enables us to define member function of Matrix type.

There are no functional changes in this commit.

Fixes: tektoncd#6277.
@afrittoli afrittoli added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Mar 3, 2023
jerop added a commit to jerop/pipeline that referenced this issue Mar 6, 2023
@jerop
Reorganizing Matrix Implementation
fbf0705 
In this change, we reorganize the code implementing Matrix.
This is to make it easier to make changes to Matrix, such as adding
Matrix.Include, as we work towards a Beta release. This refactor
also enables us to define member function of Matrix type.

There are no functional changes in this commit.

Fixes: tektoncd#6277.
jerop added a commit to jerop/pipeline that referenced this issue Mar 6, 2023
@jerop
Reorganizing Matrix Implementation
2cb9eb7 
In this change, we reorganize the code implementing Matrix.
This is to make it easier to make changes to Matrix, such as adding
Matrix.Include, as we work towards a Beta release. This refactor
also enables us to define member function of Matrix type.

There are no functional changes in this commit.

Fixes: tektoncd#6277.
tekton-robot pushed a commit that referenced this issue Mar 6, 2023
@jerop @tekton-robot
Reorganizing Matrix Implementation
771fb66 
In this change, we reorganize the code implementing Matrix.
This is to make it easier to make changes to Matrix, such as adding
Matrix.Include, as we work towards a Beta release. This refactor
also enables us to define member function of Matrix type.

There are no functional changes in this commit.

Fixes: #6277.
EmmaMunley pushed a commit to EmmaMunley/pipeline that referenced this issue Mar 7, 2023
@jerop @EmmaMunley
Reorganizing Matrix Implementation
db118d3 
In this change, we reorganize the code implementing Matrix.
This is to make it easier to make changes to Matrix, such as adding
Matrix.Include, as we work towards a Beta release. This refactor
also enables us to define member function of Matrix type.

There are no functional changes in this commit.

Fixes: tektoncd#6277.
EmmaMunley pushed a commit to EmmaMunley/pipeline that referenced this issue Mar 9, 2023
@jerop @EmmaMunley
Reorganizing Matrix Implementation
7b29af3 
In this change, we reorganize the code implementing Matrix.
This is to make it easier to make changes to Matrix, such as adding
Matrix.Include, as we work towards a Beta release. This refactor
also enables us to define member function of Matrix type.

There are no functional changes in this commit.

Fixes: tektoncd#6277.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reorganizing Matrix Implementation jerop/pipeline
2 participants
@pritidesai @afrittoli