Implement templating within stepTemplate. #1061
Conversation
tekton-robot
added
the
size/M
googlebot
added
the
cla: yes
Utilize the applyContanierReplacements() logic for the stepTemplate field. This was done for containerTemplate (now deprecated), but when stepTemplate was introduced the templating functionality was forgotten.
|
Nice! I think I'll release a patch update after this is merged too :D /lgtm |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobcatfish, EliZucker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Changes
Utilize the applyContanierReplacements() logic for the stepTemplate field. This was done for containerTemplate (now deprecated), but not stepTemplate — which was pointed out by @bobcatfish here.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.
Release Notes
Technically this is a new feature, but I think everyone expected this behavior already (following containerTemplate's behavior). I personally don't think this warrants a release note but here it is just in case: