Allow omitting metadata in volumeclaimtemplate

[jlpettersson]

Changes

Workspaces can be backed by a PVC that is created from a user provied template, e.g.

workspaces:
- name: ws
  volumeClaimTemplate:
    metadata:
      name: ws-pvc
    spec:
      accessModes: ["ReadWriteOnce"]
      resources:
         requests:
            storage: 1Gi

but this might fail if the user did not provide a metadata.name on the
template, since the PVC name would be -<ws-name>-<run-name> and names
starting with a - is not allowed for PVCs.

This commits omit the first - in the PVC name, if the user did not
provide a name or metadata part of the volumeclaimtemplate.

Now this is a valid template:

workspaces:
- name: ws
  volumeClaimTemplate:
    spec:
      accessModes: ["ReadWriteOnce"]
      resources:
         requests:
            storage: 1Gi

I also added license banners to the two pvc-related go files.

Fixes #2450

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Jonas Pettersson (9307b1a)

[tekton-robot]

Hi @jlpettersson. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ghost]

/ok-to-test

[tekton-robot]

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/volumeclaim/pvchandler.go	87.0%	88.0%	1.0

[jlpettersson]

process 474 exited with code 1 after 28.3m

/test pull-tekton-pipeline-integration-tests

[vdemeester]

/meow

[tekton-robot]

@vdemeester:

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dibyom]

/lgtm