Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce config map watcher for feature flags #2637

Merged
merged 2 commits into from
Jun 8, 2020
Merged

Introduce config map watcher for feature flags #2637

merged 2 commits into from
Jun 8, 2020

Commits on Jun 6, 2020

  1. Add feature flags to config store 

    Feature flags configuration is now tracked by the config store. This
allows watching for the corresponding config map changes, removing the
need to call kubernetes API to get the feature flags config map every
time a pod is created.

Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
    @adshmh
    adshmh committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    10b2f9a View commit details
    Browse the repository at this point in the history

  2. Use configmap watcher for feature flags config 

    Taskrun reconciler now uses a configmap watcher for `feature-flags`
configmap to remove the need for an extra Kubernetes API call to get the
configmap's value every time a pod is being created.

Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
    @adshmh
    adshmh committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    64da2b5 View commit details
    Browse the repository at this point in the history