Bump knative to enable new features #3181
Conversation
tekton-robot
added
the
do-not-merge/release-note-label-needed
tekton-robot
added
the
size/L
|
Hi @pierretasci. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tekton-robot
added
needs-ok-to-test
|
/kind feature |
tekton-robot
added
the
kind/feature
|
/ok-to-test |
tekton-robot
added
ok-to-test
| google.golang.org/api v0.25.0 | ||
| k8s.io/api v0.17.6 | ||
| k8s.io/apimachinery v0.17.6 | ||
| k8s.io/api v0.18.7-rc.0 |
There was a problem hiding this comment.
This one is weird, it should be v0.18.6
There was a problem hiding this comment.
Yeah, k8s.io/* in go.mod updated as part of updating the knative/pkg which also has same rc.0 version. See: https://github.com/knative/pkg/blob/master/go.mod#L48.
| k8s.io/api v0.17.6 | ||
| k8s.io/apimachinery v0.17.6 | ||
| k8s.io/api v0.18.7-rc.0 | ||
| k8s.io/apimachinery v0.19.0 |
There was a problem hiding this comment.
For consistency, this should be at the same level of the others, so v0.18.6
| k8s.io/kube-openapi v0.0.0-20200410145947-bcb3869e6f29 | ||
| knative.dev/pkg v0.0.0-20200702222342-ea4d6e985ba0 | ||
| knative.dev/pkg v0.0.0-20200831162708-14fb2347fb77 |
There was a problem hiding this comment.
fwiw, this is release-0.17, so we could update ./hack/update-deps.sh
diff --git a/hack/update-deps.sh b/hack/update-deps.sh
index 2d6d9cf5..1c6678dc 100755
--- a/hack/update-deps.sh
+++ b/hack/update-deps.sh
@@ -22,7 +22,7 @@ source $(git rev-parse --show-toplevel)/vendor/github.com/tektoncd/plumbing/scri
cd ${REPO_ROOT_DIR}
-VERSION="release-0.16"
+VERSION="release-0.17"
# The list of dependencies that we track at HEAD and periodically
# float forward in this repository.There was a problem hiding this comment.
./hack/update-deps --upgrade does a little bit more than that diff but that's alright.
vdemeester
added
kind/feature
|
/assign bobcatfish |
|
thanks for taking this on @pierretasci !! |
|
/lgtm Seems fairly straightforward. cc @mattmoor |
|
As a heads up, we switched to K8s 1.18 libs last week for our upcoming Glad this seemed so easy 🤩 😅 |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/test pull-tekton-pipeline-build-tests |
Changes
This PR is related to #3156 and splits out the knative version bump from that PR. Knative has some internal changes that we would like to take advantage of like the ability to configure the QPS it accepts which necessitates this version bump.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Release Notes