Clean up pkg/timeout/handler_test.go

[imjasonh]

• remove test builders
• only create relevant resources for each test case
• phrase test cases in terms of interesting taskrun traits, not whole
  taskrun resources
• run test cases checking for all namespaces and a single namespace
• remove redundant test case

#3178

@bobcatfish I started working on this and realized it might end up changing while you're working on simplifying timeout handling. If this all looks moot I'm happy to close it. Otherwise I can keep working on exorcising tb from this whole file.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• [y] Includes tests (if functionality changed/added)
• [n] Includes docs (if user facing)
• [y] Commit messages follow commit message best practices
• [y] Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

NONE

[tekton-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign bobcatfish
You can assign the PR to them by writing /assign @bobcatfish in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vdemeester]

/kind cleanup
/area testing

[vdemeester]

/lgtm

[afrittoli]

Thanks, /lgtm
Waiting for @bobcatfish to comment on this before approving

[imjasonh]

/kind cleanup

[tekton-robot]

@imjasonh: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vdemeester]

ping @imjasonh 👼

[tekton-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[imjasonh]

pkg/timeout/handler_test.go is deleted, which means it's as clean as it can get. :)