Remove test builders from validate_params_test.go

[popcor255]

Changes

• Using minimal internal types are simpler than full pipeline objects.
• Removed duplicate tests

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices
• Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

/area testing
/kind cleanup

#3178

[popcor255]

/cc @imjasonh

[popcor255]

/retest all

[popcor255]

/retest

[dlorenc]

/lgtm

[vdemeester]

Test names use underscores instead of blank spaces. Golang test convert blanks to underscores into the terminal anyway. Changing in the code base ahead of time makes it easier to find failed test in editors.

I am not really a fan of doing that change. The fact that go replace converts blank to something is an implementation detail.

A description was added to each test case.

Not a fan of that one either, the name field should be sufficient and it's gonna be extra burden to maintain. Just like most comments, it might become incorrect with what the test actually does.

[vdemeester]

/hold

[imjasonh]

Test names use underscores instead of blank spaces. Golang test convert blanks to underscores into the terminal anyway. Changing in the code base ahead of time makes it easier to find failed test in editors.

I am not really a fan of doing that change. The fact that go replace converts blank to something is an implementation detail.

+1, I've even been changing underscores to spaces in other changes 😆

Not a fan of that one either, the name field should be sufficient and it's gonna be extra burden to maintain. Just like most comments, it might become incorrect with what the test actually does.

Agree here too, test names should be short and descriptive enough to not need a longer description. If you do need to describe something in more detail, that's fine, but I'd do it in a // comment and not in code that gets printed with the test. Having name and description is also inconsistent with other tests throughout the codebase, and I don't think we should update them all to match.

[imjasonh]

/kind cleanup

Poking the kind label check 🤞

[popcor255]

@vdemeester @imjasonh Thanks for the feedback! 😄
I made the changes. Could you please can take another look?

[vdemeester]

/meow
/hold cancel

[tekton-robot]

@vdemeester:

In response to this:

/meow
/hold cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[popcor255]

poke @dlorenc

[jerop]

/lgtm