-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove YAML merge and variable from config YAML #3842
Conversation
Note: the merge syntax was added in #3236 |
/lgtm Makes it too repetitive and that's the reason #3236 had implemented configs with merge key. But, to make them consumable by other tools, we need these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, it's a shame not all tools support all features of yaml 😅
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
heeeeey @imjasonh i was randomly looking at commit messages in the repo (may have been to settle a bet which i then immediately lost) but i noticed that this has a commit message that just says "Remove YAML merge and variable from config YAML " and i want to give a plug for including more context in commit messages (even the PR description has a bit more context "This enables kustomize and ytt users to more easily consume and modify the YAML." tho as a random reader i still dont really understand why theses changes make it so that this is easier for these tools) apologies for the nag 🙏 |
Fixes #3794
This enables kustomize and ytt users to more easily consume and modify the YAML.
/kind feature
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes