Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove YAML merge and variable from config YAML #3842

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

imjasonh
Copy link
Member

Fixes #3794

This enables kustomize and ytt users to more easily consume and modify the YAML.

/kind feature

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • [n] Includes tests (if functionality changed/added)
  • [n] Includes docs (if user facing)
  • [y] Commit messages follow commit message best practices
  • [y] Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Make release.yaml more easily consumed by tools like kustomize and ytt

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Mar 17, 2021
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 17, 2021
@imjasonh
Copy link
Member Author

Note: the merge syntax was added in #3236

@pritidesai
Copy link
Member

pritidesai commented Mar 17, 2021

/lgtm

Makes it too repetitive and that's the reason #3236 had implemented configs with merge key. But, to make them consumable by other tools, we need these changes.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2021
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, it's a shame not all tools support all features of yaml 😅

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2021
@tekton-robot tekton-robot merged commit 0593c7b into tektoncd:main Mar 18, 2021
@bobcatfish
Copy link
Collaborator

heeeeey @imjasonh i was randomly looking at commit messages in the repo (may have been to settle a bet which i then immediately lost) but i noticed that this has a commit message that just says "Remove YAML merge and variable from config YAML " and i want to give a plug for including more context in commit messages (even the PR description has a bit more context "This enables kustomize and ytt users to more easily consume and modify the YAML." tho as a random reader i still dont really understand why theses changes make it so that this is easier for these tools)

apologies for the nag 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tekton release manifest is not working with kustomize and ytt
5 participants