Add test YAML helpers #3905
Merged
Add test YAML helpers #3905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These helpers take a YAML string and return parsed, deserialized typed objects. They're intended to be easier to use than Go structs or test builders, focused on showing the YAML a user would write to specify our objects.
tekton-robot
added
release-note-none
tekton-robot
added
the
size/L
|
The following is the coverage report on the affected files.
|
ghost
approved these changes
Apr 30, 2021
tekton-robot
added
the
approved
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I LOVE THIS
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These helpers take a YAML string and return parsed, deserialized typed objects. They're intended to be easier to use than Go structs or test builders, focused on showing the YAML a user would write to specify our objects.
I proposed these a long time ago, but never merged them and I don't remember why. Talking to @bobcatfish today she mentioned she might like to use them, so I'm bringing them up again. Please let me know what you think! 🙏
Some future improvements we might consider:
test/, e.g., in unit teststext/template, possibly taking an optional map of key/value replacements in the helper methods./kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes