Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows image entrypoint paths for parity with Linux #4018

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Fix Windows image entrypoint paths for parity with Linux #4018

merged 1 commit into from
Jun 10, 2021

Conversation

aiden-deloryn
Copy link
Contributor

Changes

Tekton expects to find the entrypoint binary in /ko-app/entrypoint
which is equivalent to C:\ko-app\entrypoint on Windows. See
pkg/pod/entrypoint.go:orderContainers(). Currently entrypoint is
stored in C:\ProgramData\tektoncd\pipeline\entrypoint.exe causing
this to break on Windows. To avoid the need for platform-specific
logic in the controller, and for parity with Linux, this change
updates 'entrypoint' and 'nop' images for Windows to store binaries
in C:\ko-app\.

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

@aiden-deloryn
Fix Windows image entrypoint paths for parity with Linux
50a0ef2 
Tekton expects to find the entrypoint binary in '/ko-app/entrypoint'
which is equivalent to 'C:\ko-app\entrypoint' on Windows. See
'pkg/pod/entrypoint.go:orderContainers()'. Currently entrypoint is
stored in 'C:\ProgramData\tektoncd\pipeline\entrypoint.exe' causing
this to break on Windows. To avoid the need for platform-specific
logic in the controller, and for parity with Linux, this change
updates 'entrypoint' and 'nop' images for Windows to store binaries
in 'C:\ko-app\'.
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jun 9, 2021
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 9, 2021
@tekton-robot
Copy link
Collaborator

Hi @aiden-deloryn. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 9, 2021
@aiden-deloryn
Copy link
Contributor Author

/assign @pritidesai

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2021
@ghost
Copy link

ghost commented Jun 10, 2021

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 10, 2021
@imjasonh
Copy link
Member

/lgtm

FWIW ko-build/ko#374 builds images with entrypoint configured to c:\ko-app\entrypoint, so this should be compatible when we start actually building Windows images with ko 👍

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2021
@aiden-deloryn
Copy link
Contributor Author

/retest

@tekton-robot tekton-robot merged commit ff0fbc8 into tektoncd:main Jun 10, 2021
@aiden-deloryn aiden-deloryn deleted the fix-windows-binary-paths branch June 10, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli Awaiting requested review from afrittoli

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@pritidesai pritidesai

@imjasonh imjasonh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aiden-deloryn @tekton-robot @imjasonh @pritidesai