Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comment on RunControllerName const #4065

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 30, 2021

Changes

Prior to this commit the code comment for the RunControllerName const actually described the PipelineRun controller name.

This commit updates the code comment to correctly document the custom task controller name.

/kind documentation

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE

Prior to this commit the code comment for the `RunControllerName` const actually desribed the PipelineRun controller name.

This commit updates the code comment to correctly document the custom task controller name.
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/documentation Categorizes issue or PR as related to documentation. labels Jun 30, 2021
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 30, 2021
@ghost
Copy link
Author

ghost commented Jun 30, 2021

/test tekton-pipeline-unit-tests

1 similar comment
@ghost
Copy link
Author

ghost commented Jun 30, 2021

/test tekton-pipeline-unit-tests

@ghost
Copy link
Author

ghost commented Jun 30, 2021

/test pull-tekton-pipeline-build-tests

@ghost
Copy link
Author

ghost commented Jun 30, 2021

/test pull-tekton-pipeline-integration-tests

@ghost
Copy link
Author

ghost commented Jun 30, 2021

/test pull-tekton-pipeline-build-tests

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2021
@pritidesai
Copy link
Member

thanks @sbwsg
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2021
@tekton-robot tekton-robot merged commit c0fae23 into main Jul 1, 2021
@pritidesai pritidesai deleted the sbwsg-run-controller-name-code-comment branch March 21, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants