Bump the go-scm, docker/cli and docker/docker libraries. #4205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/S
|
/kind cleanup |
tekton-robot
added
the
kind/cleanup
Both of these were quite out of date and have enough transitive dependencies that it's worth keeping closer to HEAD. It might be possible to detangle and update separately, but I couldn't get it to work on my first try. There was one manual change to error strings in pkg/pullrequest/api_test.go. I also had to re-run codegen and update the golden test data for new fields.. Signed-off-by: Dan Lorenc <dlorenc@google.com>
afrittoli
reviewed
Sep 2, 2021
There was a problem hiding this comment.
Thanks Dan, this looks good!
Just one request, could you add a note about the new version of the jx scm library, since it changes the format of the PR.json and it may have an impact on folks using the PullRequest resource.
/approve
tekton-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Both of these were quite out of date and have enough transitive dependencies
that it's worth keeping closer to HEAD. It might be possible to detangle and
update separately, but I couldn't get it to work on my first try.
There was one manual change to error strings in pkg/pullrequest/api_test.go.
I also had to re-run codegen.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes