Poll for the status of Runs #4213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today, each custom tasks implementation copies over the wait.go file to poll the status of resources for testing. This makes it hard to maintain over time. The only added function in the custom tasks testing is the polling for the status of Runs. This change adds the function to poll for the status of Runs so that this can be reused across all custom tasks testing.
tekton-robot
added
release-note
tekton-robot
added
the
size/S
3 tasks
|
/test pull-tekton-pipeline-integration-tests |
ghost
approved these changes
Sep 3, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Today, each custom task implementation copies over the wait.go file
to poll the status of resources for testing. This makes it hard to
maintain over time. The only added function in the custom tasks testing
is the polling for the status of Runs.
This change adds the function to poll for the status of Runs so that
this can be reused across all custom tasks testing.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes