-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put workspace-in-sidecar example into no-ci #4380
Conversation
The workspace-in-sidecar example has been a relatively consistent flake in our CI suite. The issue #4169 was created in August describing this problem and there have been relatively regular reports related to the example since then. To a first approximation I've found 31 individual instances of the test's failure since May across 24 separate Pull Requests. Attempts to reduce the flakiness of this example have not been successful yet. So in order to reduce the amount of noise in our CI (and hopefully increase overall trust in the suite) this commit moves the example into the no-ci folder, preventing its execution, while we continue to try and figure out why it is so flakey.
/kind flake |
/remove-kind flake |
/kind flake |
/remove-kind flake |
/kind flake |
/test check-pr-has-kind-label |
/close |
@sbwsg: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@sbwsg: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Here's a permanent link to the failed test run output. Failed Test: Ran for The test runner reported the following:
Both the sidecar and steps are reported as successful in the captured TaskRun, and both have a non-nil
The creation timestamp on the TaskRun is |
/test pull-tekton-pipeline-alpha-integration-tests |
/test check-pr-has-kind-label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Changes
The workspace-in-sidecar example has been a relatively
consistent flake in our CI suite. The issue #4169
was created in August describing this problem and
there have been relatively regular reports related to the
example since then. To a first approximation I've found 31
individual instances of the test's failure since May across
24 separate Pull Requests.
Attempts to reduce the flakiness of this example have not
been successful yet. So in order to reduce the amount of noise
in our CI (and hopefully increase overall trust in the suite)
this commit moves the example into the no-ci folder, preventing
its execution, while we continue to try and figure out why it
is so flakey.
Just to reiterate here: there's no intention to ignore
the workspace-in-sidecar example's flakiness. I'm still looking into it. But
the overall noise it adds to our CI results, I would argue, messes with the confidence
we place in the suite.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes