Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add local private registry setup doc with kind #4606

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Add local private registry setup doc with kind #4606

merged 1 commit into from
Jun 17, 2022

Conversation

Yongxuanzhang
Copy link
Member

@Yongxuanzhang Yongxuanzhang commented Feb 22, 2022 •
edited
Loading

Changes

This PR aims at adding local private docker registry setup with kind cluster. Prior this commit the doc is missing or the content is distributed.

/kind documentation

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 22, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 22, 2022
@Yongxuanzhang Yongxuanzhang marked this pull request as ready for review February 22, 2022 15:17
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2022
@jerop jerop mentioned this pull request Feb 22, 2022
Closed
@tekton-robot tekton-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Feb 23, 2022
vdemeester
vdemeester approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @afrittoli @abayer

@tekton-robot tekton-robot requested review from abayer and afrittoli May 5, 2022 08:34
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abayer
Copy link
Contributor

abayer commented May 5, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2022
afrittoli
afrittoli reviewed May 5, 2022
View reviewed changes
docs/developers/local-setup.md
Comment on lines +131 to +135
-v "$(pwd)"/auth:/auth \
-e "REGISTRY_AUTH=htpasswd" \
-e "REGISTRY_AUTH_HTPASSWD_REALM=Registry Realm" \
-e REGISTRY_AUTH_HTPASSWD_PATH=/auth/htpasswd \
registry:2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)
I suppose it might be beneficial, at least in some cases, to have the auth setup even for local development.
Perhaps worth replicating in https://github.com/tektoncd/plumbing/blob/ec7bc19a0ce8c2ece2875b714fb69182ee76c776/hack/tekton_in_kind.sh#L65-L73

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! I'm not so familiar with plumbing and all our test infra, but I'm trying to learn them as well. 😄

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label May 6, 2022
@Yongxuanzhang
add local private registry setup
e120e7a 
This PR aims at adding local private docker registry setup with kind cluster. Prior this commit the doc is missing or the content is distributed.
@Yongxuanzhang Yongxuanzhang force-pushed the add-local-registry-doc branch from a71f10f to e120e7a Compare May 6, 2022 15:06
@Yongxuanzhang Yongxuanzhang requested review from abayer and afrittoli May 6, 2022 15:44
@dibyom
Copy link
Member

dibyom commented Jun 17, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2022
@tekton-robot tekton-robot merged commit e7520a0 into tektoncd:main Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@dibyom dibyom Awaiting requested review from dibyom

@pritidesai pritidesai Awaiting requested review from pritidesai

@abayer abayer Awaiting requested review from abayer

@afrittoli afrittoli Awaiting requested review from afrittoli

Assignees

@abayer abayer

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Yongxuanzhang @tekton-robot @abayer @dibyom @vdemeester @afrittoli