Clean up the git-init base Dockerfile and Task. #4765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My previous change switched us off of the Dockerfile-based `git-init` base image in favor of `ghcr.io/distroless/git` (:tada:), however, I wanted to stagger cleaning this up so we could keep rebuilding it in case we needed to rollback. This cleans up the Dockerfile and Task, which should complete the migration. Fixes: tektoncd#4752
tekton-robot
added
release-note
tekton-robot
added
the
size/L
|
/test pull-tekton-pipeline-alpha-integration-tests |
vdemeester
approved these changes
Apr 20, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
vdemeester
added a commit
to vdemeester/tektoncd-pipeline
that referenced
this pull request
Jun 3, 2022
The task is not used and defined anymore as we removed the git-init base image Dockerfile now, we don't need it. It got removed in tektoncd#4765 but not from the `Pipeline`. This also removes it from the `kustomization.yml` file. This should help fix the plumbing issue we have with re-deploying nightly payload (`Task`, `Pipeline`, …), as the `kustomization.yml` as is was invalid. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
5 tasks
tekton-robot
pushed a commit
that referenced
this pull request
Jun 3, 2022
The task is not used and defined anymore as we removed the git-init base image Dockerfile now, we don't need it. It got removed in #4765 but not from the `Pipeline`. This also removes it from the `kustomization.yml` file. This should help fix the plumbing issue we have with re-deploying nightly payload (`Task`, `Pipeline`, …), as the `kustomization.yml` as is was invalid. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous change switched us off of the Dockerfile-based
git-initbase image in favor ofghcr.io/distroless/git(:tada:), however, I wanted to stagger cleaning this up so we could keep rebuilding it in case we needed to rollback.This cleans up the Dockerfile and Task, which should complete the migration.
Fixes: #4752
/kind cleanup
/hold
Going to leave a hold on this so we have some bake time on the distroless images. I'm sure we need at least one more change to stop running this task before we can simply delete it. cc @afrittoli @vdemeester
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
(if there are no user facing changes, use release note "NONE")
Release Notes