-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEP-0090: Matrix - Concurrency Control #4947
Conversation
[TEP-0090: Matrix][tep-0090] proposed executing a `PipelineTask` in parallel `TaskRuns` and `Runs` with substitutions from combinations of `Parameters` in a `Matrix`. In this change, we implement concurrency controls for the `Matrix` as discussed in [TEP-0090: Matrix - Concurrency Control][cc]. The default value is 256, and users can configure the value for their own installations. [tep-0090]: https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md [cc]: https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md#concurrency-control
The following is the coverage report on the affected files.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a naming nitpick-- I wonder if it would make sense to call this "maximum-matrix-combinations-count" (without the default) since there's no way to change the max matrix combinations other than this flag as far as I can tell? LGTM other than that
/lgtm |
[TEP-0090: Matrix][tep-0090] proposed executing a `PipelineTask` in parallel `TaskRuns` and `Runs` with substitutions from combinations of `Parameters` in a `Matrix`. In tektoncd#4947, we implemented the [concurrency controls][cc]. In this change, we implemented that the default value is 256 if it's not specified by the user. [tep-0090]: https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md [cc]: https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md#concurrency-control
[TEP-0090: Matrix][tep-0090] proposed executing a `PipelineTask` in parallel `TaskRuns` and `Runs` with substitutions from combinations of `Parameters` in a `Matrix`. In #4947, we implemented the [concurrency controls][cc]. In this change, we implemented that the default value is 256 if it's not specified by the user. [tep-0090]: https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md [cc]: https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md#concurrency-control
Changes
TEP-0090: Matrix proposed executing a
PipelineTask
in parallelTaskRuns
andRuns
with substitutions from combinations ofParameters
in aMatrix
.In this change, we implement concurrency controls for the
Matrix
as discussed in TEP-0090: Matrix - Concurrency Control. The default value is 256, and users can configure the value for their own installations./kind feature
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
Release Notes