Unexport RPRT member functions used within resources pkg only #4949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note-none
|
/kind cleanup |
tekton-robot
added
the
kind/cleanup
dibyom
approved these changes
Jun 8, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/test pull-tekton-pipeline-go-coverage |
|
/test tekton-pipeline-unit-tests |
Some member functions of ResolvedPipelineRunTask are exported but they are used within the resources package only: `IsDone`, `IsSuccessful`, `IsFailure`, `IsRunning` `HasRemainingRetries`, `IsCancelled`, `IsConditionStatusFalse`, and `IsStarted`. These functions, except `IsDone`, are not tested but the exported functions that use them within the resources package are tested. In this change, we unexport the above member functions that are used within resources package only. We do not add tests for the now-unexported functions as recommended in [guidelines][guidelines], but we can add them later if we change the guideline. [guidelines]: https://github.com/tektoncd/community/blob/ac0ae1b304ef515e8099f772f42b91aac1b26e6b/standards.md#tests
jerop
force-pushed
the
unexport-rprt-functions
branch
from
b5971a6
to
7acf653
Compare
|
/retest |
|
/lgtm |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Some member functions of ResolvedPipelineRunTask are exported but they are used within the resources package only:
IsDone,IsSuccessful,IsFailure,IsRunning,HasRemainingRetries,IsCancelled,IsConditionStatusFalse, andIsStarted.These functions, except
IsDone, are not tested but the exported functions that use them within the resources package are tested.In this change, we unexport the above member functions that are used within resources package only. We do not add tests for the now-unexported functions as recommended in guidelines, but we can add them later if we change the guidelines.
Follow up to refactor done in PR: #4943
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes
cc @pritidesai