Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagated Parameters replaced Implicit Parameters #4994

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

jerop
Copy link
Member

@jerop jerop commented Jun 16, 2022

Changes

Propagated Parameters was designed and implemented to replace
Implicit Parameters to remove the mutation of specifications.
In this change, we update the alpha features table to remove the
Implicit Parameters and the broken link to its documentation,
and replace them with Propagated Parameters.

TEPs:

PRs:

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [n/a] Docs included if any changes are user facing
  • [n/a] Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Release notes block below has been filled in (if there are no user facing changes, use release note "NONE")

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Jun 16, 2022
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 16, 2022
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2022
@abayer
Copy link
Contributor

abayer commented Jun 17, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2022
@jerop
Copy link
Member Author

jerop commented Jun 17, 2022

/test pull-tekton-pipeline-integration-tests

1 similar comment
@jerop
Copy link
Member Author

jerop commented Jun 17, 2022

/test pull-tekton-pipeline-integration-tests

@jerop jerop force-pushed the propagated-parameters branch from a2fc973 to a207006 Compare June 17, 2022 13:57
@tekton-robot tekton-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. labels Jun 17, 2022
Propagated `Parameters` was designed and implemented to replace
Implicit `Parameters` to remove the mutation of specifications.
In this change, we update the alpha features table to remove the
Implicit `Parameters` and the broken link to its documentation,
and replace them with Propagated `Parameters`.

TEPs:
- https://github.com/tektoncd/community/blob/main/teps/0107-propagating-parameters.md
- https://github.com/tektoncd/community/blob/main/teps/0023-implicit-mapping.md

PRs:
- tektoncd#4906
- tektoncd#4845
@jerop jerop force-pushed the propagated-parameters branch from a207006 to c3b1082 Compare June 17, 2022 13:58
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2022
@jerop
Copy link
Member Author

jerop commented Jun 17, 2022

@afrittoli @abayer had to fix a merge conflict, please take a look

@abayer
Copy link
Contributor

abayer commented Jun 17, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2022
@tekton-robot tekton-robot merged commit 53ab185 into tektoncd:main Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants