-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cherry-pick: v0.38] Add SetDefaults for pipelineSpec in reconciler #5217
[cherry-pick: v0.38] Add SetDefaults for pipelineSpec in reconciler #5217
Conversation
Cherry-picked from tektoncd#5176 This commit adds SetDefaults for pipelineSpec in reconciler after they are fetched. This is to avoid failing the resources that are not mutated to add default values. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
/assign @lbernick cc @tektoncd/core-maintainers |
/retest |
1 similar comment
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retest |
1 similar comment
/retest |
/test pull-tekton-pipeline-alpha-integration-tests |
Changes
Cherry-picked from #5176
This commit adds SetDefaults for pipelineSpec in reconciler
after they are fetched. This is to avoid failing the resources that
are not mutated to add default values.
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes