Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty paramValueType conversion #5506

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Fix empty paramValueType conversion #5506

merged 1 commit into from
Sep 19, 2022

Conversation

JeromeJu
Copy link
Member

@JeromeJu JeromeJu commented Sep 15, 2022 •
edited
Loading

Changes

This commit fixes the paramValueType that is not handled if input is an empty string,
which could lead to issues for 'marshal' in knative.

FIx: #5500
/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [n/a] Has Docs included if any changes are user facing
  • [n/a] Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [n/a] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [n/a] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesnt merit a release note. labels Sep 15, 2022
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 15, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/param_conversion.go 100.0% 95.7% -4.3

@JeromeJu JeromeJu changed the title Fix paramValueType in conversion Fix empty paramValueType conversion Sep 15, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/param_conversion.go 100.0% 91.5% -8.5

@JeromeJu JeromeJu mentioned this pull request Sep 16, 2022
Closed
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 16, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/param_conversion.go 100.0% 95.7% -4.3

@vdemeester vdemeester added this to the Pipelines v0.40 milestone Sep 19, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2022
@lbernick
Copy link
Member

@JeromeJu it looks like you might have accidentally included a go binary-- happy to lgtm once that's removed

@JeromeJu
Fix empty string paramValueType conversion
f9fa567 
This commit fixes the paramValueType that is not handled if input is an empty string,
which could lead to issues for 'marshal' in knative.
@JeromeJu
Copy link
Member Author

JeromeJu commented Sep 19, 2022 •
edited
Loading

@JeromeJu it looks like you might have accidentally included a go binary-- happy to lgtm once that's removed

Thanks @lbernick. Updated. Sorry that I'm not sure how the vscode generated this.

@lbernick
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2022
@JeromeJu
Copy link
Member Author

/retest

@vdemeester vdemeester removed this from the Pipelines v0.40 milestone Sep 19, 2022
@vdemeester vdemeester added this to the Pipelines v0.41 milestone Sep 19, 2022
@vdemeester
Copy link
Member

Well, I realize I did the release without this fix 😓
So I am moving it to 0.40.0 and will cherry-pick for a 0.40.1 near the end of the week 🙃

@vdemeester vdemeester added the needs-cherry-pick Indicates a PR needs to be cherry-pick to a release branch label Sep 19, 2022
@tekton-robot tekton-robot merged commit a5970b1 into tektoncd:main Sep 19, 2022
@vdemeester
Copy link
Member

/cherrypick release-v0.40.x

@tekton-robot tekton-robot mentioned this pull request Sep 19, 2022
Merged
@tekton-robot
Copy link
Collaborator

@vdemeester: new pull request created: #5513

In response to this:

/cherrypick release-v0.40.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbernick lbernick lbernick left review comments

@vdemeester vdemeester vdemeester approved these changes

@abayer abayer Awaiting requested review from abayer

Assignees

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. needs-cherry-pick Indicates a PR needs to be cherry-pick to a release branch release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.41
Development

Successfully merging this pull request may close these issues.

Conversion error for parameters when pipelineref.bundle is used
4 participants
@JeromeJu @tekton-robot @lbernick @vdemeester