Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cloud event flaky unit tests by adding waitgroup to fakeclient #5690

Merged
merged 1 commit into from
Nov 17, 2022
Merged

fix cloud event flaky unit tests by adding waitgroup to fakeclient #5690

merged 1 commit into from
Nov 17, 2022

Commits on Nov 16, 2022

  1. fix cloud event flaky unit tests by adding waitgroup to fakeclient 

    This commit adds waitgroup to fakeclient to avoid that some goroutines are not done when we want to collect the events.
The tests are flaky because the cloud events are sent with goroutine
but we don't wait until all goroutines done to check the events. So it
is possible that some events are not collected. The waitGroup will count when each goroutine is created and decrease the count when the goroutine is done.
This change has no impact on current code.

Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com
    @Yongxuanzhang
    Yongxuanzhang committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    5dc0417 View commit details
    Browse the repository at this point in the history