Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RunReason and CustomRunReason #5718

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Conversation

jerop
Copy link
Member

@jerop jerop commented Nov 3, 2022

Changes

Prior to this change, we did not have RunReason and CustomRunReason. As a result, there were instances where we reused TaskRunReason and PipelineRunReason. This worked because the underlying strings are the same, but it is confusing when reading the code (and reviewing changes).

In this change, we:

  • introduce RunReason and CustomRunReason
  • clean up existing reasons to use the enum
  • add three common reasons - started, running, successful and failed

/kind cleanup

Follow up to my comments in #5662 (comment) and #5662 (comment) (cc @abayer)

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [n/a] Has Docs included if any changes are user facing
  • [n/a] Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [n/a] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [n/a] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 3, 2022
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 3, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/run_types.go 59.3% 57.1% -2.1
pkg/apis/pipeline/v1beta1/customrun_types.go 59.3% 57.1% -2.1

@abayer
Copy link
Contributor

abayer commented Nov 3, 2022

fwiw, compilation failure can be found at https://prow.tekton.dev/view/gs/tekton-prow/pr-logs/pull/tektoncd_pipeline/5718/pull-tekton-pipeline-build-tests/1588255157798309888#1:build-log.txt%3A1369-1373

Prior to this change, we did not have `RunReason` and `CustomRunReason`.
As a result, there were instances where we reused `TaskRunReason` and
`PipelineRunReason`. This worked because the underlying strings are the
same, but it is confusing when reading the code (and reviewing changes).

In this change, we:
- introduce `RunReason` and `CustomRunReason`
- clean up existing reasons to use the enum
- add three common reasons - started, running, successful and failed
@abayer
Copy link
Contributor

abayer commented Nov 3, 2022

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/run_types.go 59.3% 57.1% -2.1
pkg/apis/pipeline/v1beta1/customrun_types.go 59.3% 57.1% -2.1

@tekton-robot
Copy link
Collaborator

The following Tekton test failed:

Test name Commit Details Required Rerun command
check-pr-has-kind-label a2044ac link true /test check-pr-has-kind-label

@lbernick
Copy link
Member

lbernick commented Nov 7, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2022
@jerop
Copy link
Member Author

jerop commented Nov 7, 2022

events flake

/test tekton-pipeline-unit-tests

@tekton-robot tekton-robot merged commit 80e3a89 into tektoncd:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants