Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flaky k8s event tests with new fakerecorder #5770

Closed
wants to merge 1 commit into from
Closed

fix flaky k8s event tests with new fakerecorder #5770

wants to merge 1 commit into from

Conversation

Yongxuanzhang
Copy link
Member

@Yongxuanzhang Yongxuanzhang commented Nov 16, 2022 •
edited
Loading

Changes

This commits fixes flaky k8s event test, #5748. The tests are flaky
because we have a timer eventsFromChannel and it may lead to some
events are not collected and cause errors.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesnt merit a release note. labels Nov 16, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 16, 2022
@Yongxuanzhang
Copy link
Member Author

/test tekton-pipeline-unit-tests

@lbernick lbernick self-assigned this Nov 17, 2022
@Yongxuanzhang Yongxuanzhang mentioned this pull request Nov 17, 2022
Merged
7 tasks
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 18, 2022
@Yongxuanzhang Yongxuanzhang mentioned this pull request Nov 21, 2022
Closed
7 tasks
@Yongxuanzhang
fix flaky k8s event tests
00b8009 
This commits fixes flaky k8s event test, tektoncd#5748. The tests are flaky
because we have a timer `eventsFromChannel` and it may lead to some
events are not collected and cause errors.
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from lbernick after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2022
@Yongxuanzhang
Copy link
Member Author

/kind flake

@tekton-robot tekton-robot added the kind/flake Categorizes issue or PR as related to a flakey test label Nov 21, 2022
@Yongxuanzhang Yongxuanzhang changed the title New fakerecorder fix flaky k8s event tests with new fakerecorder Nov 21, 2022
@Yongxuanzhang
Copy link
Member Author

/test tekton-pipeline-unit-tests

@Yongxuanzhang Yongxuanzhang mentioned this pull request Nov 30, 2022
Merged
7 tasks
@tekton-robot
Copy link
Collaborator

@Yongxuanzhang: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2022
@lbernick
Copy link
Member

@Yongxuanzhang we're still seeing this flake quite consistently, I think we should prioritize this fix! thanks for working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@lbernick lbernick

Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/flake Categorizes issue or PR as related to a flakey test needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yongxuanzhang @tekton-robot @lbernick