-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update pre-requsites to include checking docker is installed #6121
update pre-requsites to include checking docker is installed #6121
Conversation
|
Hi @pavanstarmanwar. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pavanstarmanwar welcome to tekton!
/meow
/kind documentation
/ok-to-test
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @pritidesai |
thank you @pavanstarmanwar for your contribution! Welcome to the tekton community 🎉 Please submit the checklist in the PR description. The additional check looks good to me. I would suggest (a followup PR) to include an additional section |
c0540fa
to
fc0edfe
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thank you @pavanstarmanwar 👍 /lgtm |
@@ -22,6 +22,7 @@ This guide explains how to install Tekton Pipelines. | |||
## Prerequisites | |||
|
|||
- A [Kubernetes cluster][k8s] running version 1.23 or later. | |||
- If you are running on `macOS`, make sure Docker is running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why only when running macOS
? Why Docker?
This is a list of prerequisites for installing Tekton on Kubernetes - the first in the list is a Kubernetes cluster - the procedure is not really specific to where that kubernetes cluster is running.
Thank you @pavanstarmanwar for your contribution! The old installation guide was referring to The starting point for this document is a running k8s cluster, so I don't think that docker and troubleshooting about FYI @geriom @pritidesai I would propose to revert this PR. |
I agree with you. This information is specifically about I'm reverting the changes in #6172 which also adds a bunch of missing links. |
Changes
After starting docker
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes