Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PipelineRunStatus from deprecation.md #6164

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

JeromeJu
Copy link
Member

@JeromeJu JeromeJu commented Feb 14, 2023

Changes

The pipelinerun.status.taskruns and pipelinerun.status.runs have been
removed from the codebase, therefore updating the deprecation.md.

/kind documentation

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • [n/a] Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 14, 2023
@JeromeJu
Copy link
Member Author

/kind documentation

@tekton-robot tekton-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Feb 14, 2023
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 14, 2023
@tekton-robot
Copy link
Collaborator

@JeromeJu: The label(s) kind/remove cannot be applied, because the repository doesn't have them.

In response to this:

/kind remove

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

@JeromeJu: The label(s) kind/delete cannot be applied, because the repository doesn't have them.

In response to this:

/kind delete misc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JeromeJu
Copy link
Member Author

/kind documentation

@tekton-robot
Copy link
Collaborator

@JeromeJu: The label(s) kind/delete cannot be applied, because the repository doesn't have them.

In response to this:

/kind delete misc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Yongxuanzhang
Copy link
Member

/remove-kind misc

@tekton-robot tekton-robot removed the kind/misc Categorizes issue or PR as a miscellaneuous one. label Feb 14, 2023
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeromeJu please add more details in the commit message, such as a reference to the PRs where the fields and feature flag were removed

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2023
@jerop
Copy link
Member

jerop commented Feb 15, 2023

/test @tekton-robot pull-tekton-pipeline-go-coverage-df

@tekton-robot
Copy link
Collaborator

@jerop: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-beta-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test @tekton-robot pull-tekton-pipeline-go-coverage-df

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@lbernick lbernick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you note in the commit message that these fields have already been removed?

docs/deprecations.md Outdated Show resolved Hide resolved
The `pipelinerun.status.taskruns` and `pipelinerun.status.runs` have been
removed from the codebase, therefore updating the deprecation.md.
@lbernick
Copy link
Member

@JeromeJu please add more details in the commit message, such as a reference to the PRs where the fields and feature flag were removed

+1, can you please update the PR description to reference the PRs where the fields were removed?

/lgtm
(description can be edited after the PR is merged)

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2023
@tekton-robot tekton-robot merged commit f3e9fc1 into tektoncd:main Feb 15, 2023
@JeromeJu
Copy link
Member Author

@JeromeJu please add more details in the commit message, such as a reference to the PRs where the fields and feature flag were removed

+1, can you please update the PR description to reference the PRs where the fields were removed?

/lgtm (description can be edited after the PR is merged)

Thanks Lee! Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants