Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0118: Add exported functions for validating Matrix.Include and Matrix.Params #6229

Merged
merged 1 commit into from
Feb 24, 2023
Merged

TEP-0118: Add exported functions for validating Matrix.Include and Matrix.Params #6229

merged 1 commit into from
Feb 24, 2023

Conversation

EmmaMunley
Copy link
Contributor

Changes

TEP-0118 proposed adding include as a new field within matrix

This commit adds functions that will be used to validate if MatrixHasInclude or MatrixHasParams(), which will be used in subsequent PRs as validation and implementation logic is built out.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 24, 2023
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 24, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_types.go 97.2% 97.2% 0.0
pkg/apis/pipeline/v1beta1/pipeline_types.go 96.7% 96.8% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_types.go 97.2% 97.2% 0.0
pkg/apis/pipeline/v1beta1/pipeline_types.go 96.7% 96.8% 0.0

lbernick
lbernick approved these changes Feb 24, 2023
View reviewed changes
pkg/apis/pipeline/v1beta1/pipeline_types_test.go Outdated Show resolved Hide resolved
pkg/apis/pipeline/v1beta1/pipeline_types_test.go Outdated Show resolved Hide resolved
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2023
@EmmaMunley EmmaMunley force-pushed the matrix-include-exported-functions branch from 97c1b71 to e18d70b Compare February 24, 2023 17:03
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_types.go 97.2% 97.2% 0.0
pkg/apis/pipeline/v1beta1/pipeline_types.go 96.7% 96.8% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_types.go 97.2% 97.2% 0.0
pkg/apis/pipeline/v1beta1/pipeline_types.go 96.7% 96.8% 0.0

@EmmaMunley EmmaMunley force-pushed the matrix-include-exported-functions branch from e18d70b to 2084ff8 Compare February 24, 2023 18:22
@EmmaMunley EmmaMunley force-pushed the matrix-include-exported-functions branch from 2084ff8 to ffc101d Compare February 24, 2023 18:24
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_types.go 97.2% 97.2% 0.0
pkg/apis/pipeline/v1beta1/pipeline_types.go 96.7% 96.8% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_types.go 97.2% 97.2% 0.0
pkg/apis/pipeline/v1beta1/pipeline_types.go 96.7% 96.8% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_types.go 97.2% 97.2% 0.0
pkg/apis/pipeline/v1beta1/pipeline_types.go 96.7% 96.8% 0.0

@EmmaMunley
TEP-0118: Add exported functions for validating Matrix.Include and Ma…
fa00e7a 
…trix.Params

This commit adds functions that will be used to validate if MatrixHasInclude or MatrixHasParams(), which will be used in subsequent PRs as validation and implementation logic is built out.
@EmmaMunley EmmaMunley force-pushed the matrix-include-exported-functions branch from ffc101d to fa00e7a Compare February 24, 2023 19:03
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_types.go 97.2% 97.2% 0.0
pkg/apis/pipeline/v1beta1/pipeline_types.go 96.7% 96.8% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_types.go 97.2% 97.2% 0.0
pkg/apis/pipeline/v1beta1/pipeline_types.go 96.7% 96.8% 0.0

jerop
jerop reviewed Feb 24, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2023
@tekton-robot tekton-robot merged commit e813a6a into tektoncd:main Feb 24, 2023
@EmmaMunley EmmaMunley mentioned this pull request Feb 27, 2023
Closed
7 tasks
@EmmaMunley EmmaMunley deleted the matrix-include-exported-functions branch February 28, 2023 16:36
@EmmaMunley EmmaMunley mentioned this pull request Mar 13, 2023
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop jerop left review comments

@lbernick lbernick lbernick approved these changes

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EmmaMunley @tekton-robot @jerop @lbernick