Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor extracting parameters from a PipelineTask #6344

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

EmmaMunley
Copy link
Contributor

@EmmaMunley EmmaMunley commented Mar 10, 2023

Changes

This commit adds a PipelineTask method to extract all parameters and refactors
validatePipelineContextVariables using this method.

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 10, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_types.go 96.9% 97.1% 0.2
pkg/apis/pipeline/v1/pipeline_validation.go 99.0% 99.0% -0.1
pkg/apis/pipeline/v1beta1/pipeline_types.go 96.3% 96.6% 0.3
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% -0.1

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_types.go 96.9% 97.1% 0.2
pkg/apis/pipeline/v1/pipeline_validation.go 99.0% 99.0% -0.1
pkg/apis/pipeline/v1beta1/pipeline_types.go 96.3% 96.6% 0.3
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% -0.1

@JeromeJu
Copy link
Member

suggestions for PR message:
pipelineTask(nit)
validatePipelineContextVariablesInParamValues() -> validatePipelineContextVariables since it is the caller

pkg/apis/pipeline/v1/pipeline_types.go Outdated Show resolved Hide resolved
pkg/apis/pipeline/v1/pipeline_validation.go Outdated Show resolved Hide resolved
@jerop jerop added this to the Pipelines v0.46 milestone Mar 10, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_types.go 96.9% 97.1% 0.2
pkg/apis/pipeline/v1/pipeline_validation.go 99.0% 99.0% -0.1
pkg/apis/pipeline/v1beta1/pipeline_types.go 96.3% 96.5% 0.2
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% -0.1

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_types.go 96.9% 97.1% 0.2
pkg/apis/pipeline/v1/pipeline_validation.go 99.0% 99.0% -0.1
pkg/apis/pipeline/v1beta1/pipeline_types.go 96.3% 96.5% 0.2
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% -0.1

Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @EmmaMunley!

pkg/apis/pipeline/v1/param_types.go Outdated Show resolved Hide resolved
pkg/apis/pipeline/v1/pipeline_types.go Outdated Show resolved Hide resolved
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2023
This commit adds a PipelinTask method to extract all parameters and refactors validatePipelineContextVariablesInParamValues() using this method.
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_types.go 96.9% 97.1% 0.2
pkg/apis/pipeline/v1/pipeline_validation.go 99.0% 99.0% -0.1
pkg/apis/pipeline/v1beta1/pipeline_types.go 96.3% 96.5% 0.2
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% -0.1

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_types.go 96.9% 97.1% 0.2
pkg/apis/pipeline/v1/pipeline_validation.go 99.0% 99.0% -0.1
pkg/apis/pipeline/v1beta1/pipeline_types.go 96.3% 96.5% 0.2
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% -0.1

@Yongxuanzhang
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2023
@tekton-robot tekton-robot merged commit 45269ca into tektoncd:main Mar 13, 2023
@EmmaMunley EmmaMunley deleted the refactor-pipeline-params branch March 13, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants