TEP-0118: Apply Param and Result Replacements in Matrix #6345

EmmaMunley · 2023-03-10T18:18:15Z

Changes

[TEP-0090: Matrix] introduced Matrix to the PipelineTask specification such that the PipelineTask executes a list of TaskRuns or Runs in parallel with the specified list of inputs for a Parameter or with different combinations of the inputs for a set of Parameters.

To build on this, Tep-0018 introduced Matrix.Include, which allows passing in a specific combinations of Parameters into the Matrix.

This PR updates replacement functionality for applying parameters specific to matrix parameters including matrix include parameters.
Matrix.params can have array replacements from array params or string replacements from string, array and object params.
Matrix.Include params can only have string replacements from string, array and object params.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs included if any changes are user facing
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including
functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Matrix.params can have array replacements from array params or string replacements from string, array and object params.
Matrix.Include params can only have string replacements from string, array and object params

tekton-robot · 2023-03-10T18:23:43Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/apply.go	97.5%	98.0%	0.6

tekton-robot · 2023-03-10T18:25:43Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/apply.go	97.5%	98.0%	0.6

pkg/reconciler/pipelinerun/resources/apply_test.go

pkg/reconciler/pipelinerun/resources/apply.go

EmmaMunley

Thanks @lbernick

pkg/reconciler/pipelinerun/resources/apply_test.go

pkg/reconciler/pipelinerun/resources/apply.go

tekton-robot · 2023-03-13T16:40:29Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/apply.go	97.5%	98.0%	0.6

tekton-robot · 2023-03-13T16:42:35Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/apply.go	97.5%	98.0%	0.6

pkg/reconciler/pipelinerun/resources/apply_test.go

tekton-robot · 2023-03-13T21:12:20Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/apply.go	97.5%	98.0%	0.6

tekton-robot · 2023-03-13T21:18:24Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/apply.go	97.5%	98.0%	0.6

jerop

@EmmaMunley requesting some changes in the replacements

pkg/reconciler/pipelinerun/resources/apply_test.go

pkg/reconciler/pipelinerun/resources/apply.go

tekton-robot · 2023-03-15T04:26:28Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/apply.go	97.5%	98.0%	0.6

tekton-robot · 2023-03-15T04:36:02Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/apply.go	97.5%	98.0%	0.6

tekton-robot · 2023-03-15T04:42:19Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/apply.go	97.5%	98.0%	0.6

jerop

we do not yet support array replacements from array results - #5925

pkg/reconciler/pipelinerun/resources/apply.go

tekton-robot · 2023-03-15T13:34:30Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/apply.go	97.5%	98.0%	0.6

tekton-robot · 2023-03-15T13:37:54Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/apply.go	97.5%	98.0%	0.6

tekton-robot · 2023-03-15T13:38:13Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/apply.go	97.5%	98.0%	0.6

jerop · 2023-03-15T15:33:05Z

/test pull-tekton-pipeline-build-tests

jerop

Thank you @EmmaMunley 🎉

pkg/reconciler/pipelinerun/resources/apply_test.go

tekton-robot · 2023-03-15T15:42:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jerop]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This commit updates replacement functionality for applying parameters specific to matrix parameters including matrix include parameters. Matrix.params can have array replacements from array params or string replacements from string, array and object params. Matrix.Include params can only have string replacements from string, array and object params. Note: This feature is still in preview mode.

tekton-robot · 2023-03-15T16:03:19Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/apply.go	97.5%	98.0%	0.6

tekton-robot · 2023-03-15T16:03:40Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/apply.go	97.5%	98.0%	0.6

jerop · 2023-03-15T17:46:05Z

/unhold

chitrangpatel · 2023-03-15T17:54:47Z

/lgtm

pritidesai · 2023-03-15T18:15:00Z

Please add release note for feature PRs 🙏

tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesnt merit a release note. labels Mar 10, 2023

tekton-robot requested review from dibyom and imjasonh March 10, 2023 18:18

tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 10, 2023

jerop added this to the Pipelines v0.46 milestone Mar 10, 2023

EmmaMunley mentioned this pull request Mar 10, 2023

TEP-0118: Enable pipeline to handle matrix include params #6248

Closed

7 tasks

lbernick reviewed Mar 10, 2023

View reviewed changes

EmmaMunley commented Mar 13, 2023

View reviewed changes

EmmaMunley force-pushed the apply-replacements branch from 515dba1 to b018457 Compare March 13, 2023 16:35

EmmaMunley requested review from lbernick and removed request for imjasonh and dibyom March 13, 2023 16:37

EmmaMunley requested review from jerop and lbernick and removed request for lbernick and jerop March 13, 2023 16:41

jerop reviewed Mar 13, 2023

View reviewed changes

pkg/reconciler/pipelinerun/resources/apply_test.go Outdated Show resolved Hide resolved

EmmaMunley force-pushed the apply-replacements branch from b018457 to 335a5bc Compare March 13, 2023 21:05

EmmaMunley mentioned this pull request Mar 13, 2023

TEP-0118: Matrix with Explicit Combinations of Parameters #6351

Closed

16 tasks

jerop requested changes Mar 14, 2023

View reviewed changes

pkg/reconciler/pipelinerun/resources/apply_test.go Outdated Show resolved Hide resolved

pkg/reconciler/pipelinerun/resources/apply.go Outdated Show resolved Hide resolved

EmmaMunley force-pushed the apply-replacements branch from 335a5bc to 10f0959 Compare March 14, 2023 15:31

jerop requested changes Mar 15, 2023

View reviewed changes

pkg/reconciler/pipelinerun/resources/apply.go Outdated Show resolved Hide resolved

EmmaMunley force-pushed the apply-replacements branch 2 times, most recently from e2d2649 to 238a961 Compare March 15, 2023 13:31

jerop approved these changes Mar 15, 2023

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2023

EmmaMunley force-pushed the apply-replacements branch from 238a961 to a2baf31 Compare March 15, 2023 15:57

EmmaMunley requested a review from Yongxuanzhang March 15, 2023 15:59

This was referenced Mar 15, 2023

TEP-0118: Apply PipelineTask Context Replacements in Matrix Include #6358

Merged

TEP-0118: Implement Fanning Out logic to support Matrix Include Parameters in a Task Run #6341

Merged

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2023

tekton-robot assigned chitrangpatel Mar 15, 2023

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2023

tekton-robot merged commit f0f471a into tektoncd:main Mar 15, 2023

EmmaMunley deleted the apply-replacements branch March 15, 2023 18:40

tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Mar 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TEP-0118: Apply Param and Result Replacements in Matrix #6345

TEP-0118: Apply Param and Result Replacements in Matrix #6345

EmmaMunley commented Mar 10, 2023 •

edited

Loading

tekton-robot commented Mar 10, 2023

tekton-robot commented Mar 10, 2023

EmmaMunley left a comment

tekton-robot commented Mar 13, 2023

tekton-robot commented Mar 13, 2023

tekton-robot commented Mar 13, 2023

tekton-robot commented Mar 13, 2023

jerop left a comment

tekton-robot commented Mar 15, 2023

tekton-robot commented Mar 15, 2023

tekton-robot commented Mar 15, 2023

jerop left a comment

tekton-robot commented Mar 15, 2023

tekton-robot commented Mar 15, 2023

tekton-robot commented Mar 15, 2023

jerop commented Mar 15, 2023

jerop left a comment

tekton-robot commented Mar 15, 2023

tekton-robot commented Mar 15, 2023

tekton-robot commented Mar 15, 2023

jerop commented Mar 15, 2023

chitrangpatel commented Mar 15, 2023

pritidesai commented Mar 15, 2023

TEP-0118: Apply Param and Result Replacements in Matrix #6345

TEP-0118: Apply Param and Result Replacements in Matrix #6345

Conversation

EmmaMunley commented Mar 10, 2023 • edited Loading

Changes

Submitter Checklist

Release Notes

tekton-robot commented Mar 10, 2023

tekton-robot commented Mar 10, 2023

EmmaMunley left a comment

Choose a reason for hiding this comment

tekton-robot commented Mar 13, 2023

tekton-robot commented Mar 13, 2023

tekton-robot commented Mar 13, 2023

tekton-robot commented Mar 13, 2023

jerop left a comment

Choose a reason for hiding this comment

tekton-robot commented Mar 15, 2023

tekton-robot commented Mar 15, 2023

tekton-robot commented Mar 15, 2023

jerop left a comment

Choose a reason for hiding this comment

tekton-robot commented Mar 15, 2023

tekton-robot commented Mar 15, 2023

tekton-robot commented Mar 15, 2023

jerop commented Mar 15, 2023

jerop left a comment

Choose a reason for hiding this comment

tekton-robot commented Mar 15, 2023

tekton-robot commented Mar 15, 2023

tekton-robot commented Mar 15, 2023

jerop commented Mar 15, 2023

chitrangpatel commented Mar 15, 2023

pritidesai commented Mar 15, 2023

EmmaMunley commented Mar 10, 2023 •

edited

Loading