divide ApplyTaskResultsToPipelineResults tests into success and error #6388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit divides ApplyTaskResultsToPipelineResults unit tests into success and error, two separate tests to improve the readibility and easier to find bugs. Before this commit, the unit test doesn't check the case when the return error is not nil but expect nil, and some errors are not checked. Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com
tekton-robot
added
release-note-none
Yongxuanzhang
force-pushed
the
refactor-test-pipelineresults
branch
from
f0e0dda to
72804c3
Compare
dibyom
reviewed
Mar 17, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
pritidesai
reviewed
Mar 18, 2023
| @@ -3764,6 +3709,164 @@ func TestApplyTaskResultsToPipelineResults(t *testing.T) { | |||
| }}, | |||
| }, | |||
| expectedResults: nil, | |||
| }, { | |||
| description: "multiple-results-multiple-successful-tasks ", | |||
There was a problem hiding this comment.
NIT: extra space after tasks "
pritidesai
reviewed
Mar 18, 2023
| skippedTasks: []v1beta1.SkippedTask{{ | ||
| Name: "skippedTask", | ||
| }}, | ||
| expectedResults: nil, |
There was a problem hiding this comment.
same as @dibyom's comment ⬇️ expectedResults is nil by default
There was a problem hiding this comment.
we keep the definition but no need to initialize to nil here
|
thanks a bunch @Yongxuanzhang for organizing these tests, I left some NITs, please feel free to address them in a separate PR. /lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This commit divides ApplyTaskResultsToPipelineResults unit tests into success and error, two separate tests to improve the readability and easier to find bugs. Before this commit, the unit test doesn't check the case when the return error is not nil but expect nil, and some errors are not checked.
No functional changes, but fix some tests bugs.
/kind misc
Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes