Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Matrix Implementation #6407

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Refactor Matrix Implementation #6407

merged 1 commit into from
Mar 22, 2023

Conversation

EmmaMunley
Copy link
Contributor

@EmmaMunley EmmaMunley commented Mar 21, 2023 •
edited by jerop
Loading

Changes

In this change, we refactor code implementing Matrix.Include, including:

  • Updating the struct backing the Matrix.Include type from []MatrixInclude to IncludeParamsList
    • IncludeParamsList that allows us create member functions of Matrix.Include
  • Exporting functions that will be used in subsequent PRs that implement Matrix.Include
  • Removing ResolvedPipelineTask.IsMatrixed() and reusing PipelineTask.ResolvedPipelineTask()

There are no functional changes in this commit.

/kind Cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 21, 2023
@tekton-robot tekton-robot requested review from dibyom and imjasonh March 21, 2023 02:57
@EmmaMunley
Copy link
Contributor Author

/assign @jerop @lbernick
cc: @pritidesai

@EmmaMunley EmmaMunley force-pushed the include-matrix-refactor branch 4 times, most recently from dd3715f to 8815b07 Compare March 21, 2023 15:40
@jerop
Copy link
Member

jerop commented Mar 21, 2023 •
edited
Loading

TestHermeticTaskRun failed but is unrelated - #4567

/retest

@lbernick
Copy link
Member

@EmmaMunley could you add a bit more detail to the commit message on the "why" of this change? I don't quite understand why this will make future changes easier

@jerop jerop added this to the Pipelines v0.47 milestone Mar 21, 2023
@EmmaMunley EmmaMunley force-pushed the include-matrix-refactor branch from 8815b07 to 72bdbb6 Compare March 21, 2023 16:55
@EmmaMunley
Copy link
Contributor Author

EmmaMunley commented Mar 21, 2023 •
edited
Loading

@EmmaMunley could you add a bit more detail to the commit message on the "why" of this change? I don't quite understand why this will make future changes easier

@lbernick Sure just updated the commit message. Most of the changes are to the tests to reflect the updated struct, which is used to create member functions. Also found that there were still old []Params instead of Params being used in testing.

jerop
jerop requested changes Mar 21, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the refactor separately @EmmaMunley!

@EmmaMunley EmmaMunley force-pushed the include-matrix-refactor branch from 72bdbb6 to c94c98c Compare March 21, 2023 18:26
@EmmaMunley EmmaMunley requested review from jerop and removed request for imjasonh and dibyom March 21, 2023 18:31
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 21, 2023
@EmmaMunley EmmaMunley force-pushed the include-matrix-refactor branch 2 times, most recently from 7880352 to 5b225d1 Compare March 21, 2023 19:52
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.0% 96.0% -0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.0% 96.0% -0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.0% 96.0% -0.0

@EmmaMunley EmmaMunley mentioned this pull request Mar 21, 2023
Merged
4 tasks
@EmmaMunley
Copy link
Contributor Author

EmmaMunley commented Mar 21, 2023 •
edited
Loading

Note: This PR is blocking the subsequent PRs:
#6418
#6341

cc: @jerop @lbernick @pritidesai

@EmmaMunley EmmaMunley mentioned this pull request Mar 21, 2023
Merged
7 tasks
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2023
@EmmaMunley
Refactor Matrix Implementation
9ad61aa 
In this change, we refactor code implementing Matrix.Include, including:
- Updating the struct backing the Matrix.Include type from []MatrixInclude to IncludeParamsList
   - IncludeParamsList that allows us create member functions of Matrix.Include
- Exporting functions that will be used in subsequent PRs that implement Matrix.Include
- Removing ResolvedPipelineTask.IsMatrixed() and reusing PipelineTask.ResolvedPipelineTask()
@EmmaMunley EmmaMunley requested a review from lbernick March 22, 2023 14:36
@EmmaMunley EmmaMunley mentioned this pull request Mar 22, 2023
Closed
16 tasks
@EmmaMunley EmmaMunley force-pushed the include-matrix-refactor branch from 5b225d1 to 9ad61aa Compare March 22, 2023 17:24
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.0% 96.0% -0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.0% 96.0% -0.0

@lbernick
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2023
@tekton-robot tekton-robot merged commit 013ffad into tektoncd:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop jerop approved these changes

@lbernick lbernick Awaiting requested review from lbernick

Assignees

@jerop jerop

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.47
Development

Successfully merging this pull request may close these issues.
4 participants
@EmmaMunley @jerop @lbernick @tekton-robot