You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses two issues with ResolutionRequest conversion. First, it updates the "hubVersion" to v1alpha1, since v1alpha1 is the version that supports conversion between versions, and addresses an incorrect comment about what "hubVersion" represents.
Second, it adds conversion for ResolutionRequest statuses.
It updates tests to test the round trip conversion instead of one-way conversion,
as this helps avoid bugs with copy-paste.
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
n/a Release notes contains the string "action required" if the change requires additional action from users switching to the new release
Release Notes
bug fix: reduced webhook log spam related to conversion of ResolutionRequests
This commit addresses two issues with ResolutionRequest conversion.
First, it updates the "hubVersion" to v1alpha1, since v1alpha1 is the version that
supports conversion between versions, and addresses an incorrect comment about
what "hubVersion" represents.
Second, it adds conversion for ResolutionRequest statuses.
It updates tests to test the round trip conversion instead of one-way conversion,
as this helps avoid bugs with copy-paste.
approvedIndicates a PR has been approved by an approver from all required OWNERS files.kind/bugCategorizes issue or PR as related to a bug.lgtmIndicates that a PR is ready to be merged.release-noteDenotes a PR that will be considered when it comes time to generate release notes.size/LDenotes a PR that changes 100-499 lines, ignoring generated files.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tekton-robot
added
release-note
This commit addresses two issues with ResolutionRequest conversion. First, it updates the "hubVersion" to v1alpha1, since v1alpha1 is the version that supports conversion between versions, and addresses an incorrect comment about what "hubVersion" represents.
Second, it adds conversion for ResolutionRequest statuses.
It updates tests to test the round trip conversion instead of one-way conversion,
as this helps avoid bugs with copy-paste.
/kind bug
Closes #6442
Closes #6075
Closes #5873
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes